[Main] Merge release/8.0 into main

Directory.Build.targets

@@ -26,7 +26,7 @@
     <NoWarn>$(NoWarn);AD0001</NoWarn>
 
     <!-- Experimental warnings are for customers, not for this repo -->
-    <NoWarn>$(NoWarn);EXTEXP0001;EXTEXP0002;EXTEXP0003;EXTEXP0004;EXTEXP0005;EXTEXP0006;EXTEXP0007;EXTEXP0008;EXTEXP0009;EXTEXP0010;EXTEXP0011;EXTEXP0012;EXTEXP0013</NoWarn>
+    <NoWarn>$(NoWarn);EXTEXP0001;EXTEXP0002;EXTEXP0003;EXTEXP0004;EXTEXP0005;EXTEXP0006;EXTEXP0007;EXTEXP0008;EXTEXP0009;EXTEXP0010;EXTEXP0011;EXTEXP0012;EXTEXP0013;EXTEXP0014;EXTEXP0015;EXTEXP0016;EXTEXP0017</NoWarn>
 
     <!-- NU5104: A stable release of a package should not have a prerelease dependency -->
     <NoWarn>$(NoWarn);NU5104</NoWarn>
@@ -53,7 +53,7 @@
 
   <ItemGroup Condition="'$(Stage)' == 'dev' AND '$(OutputType)' != 'Exe' AND '$(Api)' != 'false'">
     <AssemblyAttribute Include="System.Diagnostics.CodeAnalysis.ExperimentalAttribute">
-      <_Parameter1>TBD</_Parameter1>
+      <_Parameter1>$(StageDevDiagnosticId)</_Parameter1>
       <_Parameter2>UrlFormat = "https://aka.ms/dotnet-extensions-warnings/{0}"</_Parameter2>
       <_Parameter2_IsLiteral>true</_Parameter2_IsLiteral>
     </AssemblyAttribute>

NuGet.config

@@ -2,6 +2,11 @@
 <configuration>
   <packageSources>
     <clear />
+    <!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.-->
+    <!--  Begin: Package sources from dotnet-runtime -->
+    <add key="darc-pub-dotnet-runtime-488a8a3" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-488a8a35/nuget/v3/index.json" />
+    <!--  End: Package sources from dotnet-runtime -->
+    <!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
     <!-- Arcade -->
     <add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" />
     <add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />
@@ -14,6 +19,9 @@
   <!-- Define mappings by adding package patterns beneath the target source. 
        https://aka.ms/nuget-package-source-mapping  -->
   <packageSourceMapping>
+    <packageSource key="darc-pub-dotnet-runtime-488a8a3">
+      <package pattern="*" />
+    </packageSource>
     <packageSource key="dotnet-public">
       <package pattern="*" />
     </packageSource>

README.md

@@ -2,17 +2,14 @@
 
 This repository contains a suite of libraries that provide facilities commonly needed when creating production-ready applications. Initially developed to support high-scale and high-availability services within Microsoft, such as Microsoft Teams, these libraries deliver functionality that can help make applications more efficient, more robust, and more manageable.
 
-The code in this repo is preliminary and will be released in stable form with .NET 8
-
 The major functional areas this repo addresses are:
-- Compliance: Mechanisms to help manage application data according to privacy regulations and policies, which includes a data annotation framework, supporting analyzers, audit report generation, and telemetry redaction.
+- Compliance: Mechanisms to help manage application data according to privacy regulations and policies, which includes a data annotation framework, audit report generation, and telemetry redaction.
 - Diagnostics: Provides a set of APIs that can be used to gather and report diagnostic information about the health of a service.
 - Contextual Options: Extends the .NET Options model to enable experimentations in production.
-- Resilience: Builds on top of the popular Polly library to provide sophisticated resilience pipelines along with support for chaos engineering to make applications robust to transient errors.
+- Resilience: Builds on top of the popular Polly library to provide sophisticated resilience pipelines to make applications robust to transient errors.
 - Telemetry: Sophisticated telemetry facilities provide enhanced logging, metering, tracing, and latency measuring functionality.
 - AspNetCore extensions: Provides different middlewares and extensions that can be used to build high-performance and high-availability ASP.NET Core services.
-- Cloud Abstractions: A growing set of abstractions representing common cloud-native service types, making it possible to write applications that can work across multiple cloud providers with relative ease.
-- Static Analysis: Provides a set of Roslyn analyzers that can be used to enforce best practices and coding standards.
+- Static Analysis: Curated static analysis settings to help improve your code.
 - Testing: Dramatically simplifies testing around common .NET abstractions such as ILogger and the TimeProvider.
 
 [![Build Status](https://dev.azure.com/dnceng/internal/_apis/build/status/r9/dotnet-r9?branchName=main)](https://dev.azure.com/dnceng/internal/_build/latest?definitionId=1223&branchName=main)

azure-pipelines.yml

@@ -56,27 +56,18 @@ variables:
 
   - name: runAsPublic
     value: ${{ eq(variables['System.TeamProject'], 'public') }}
+
   - name: _BuildConfig
     value: Release
   - name: isOfficialBuild
     value: ${{ and(ne(variables['runAsPublic'], 'true'), notin(variables['Build.Reason'], 'PullRequest')) }}
-  - name: IsDeltaBuild
-    value: ${{ eq(variables['Build.Reason'], 'PullRequest') }}
   - name: Build.Arcade.ArtifactsPath
     value: $(Build.SourcesDirectory)/artifacts/
   - name: Build.Arcade.LogsPath
     value: $(Build.Arcade.ArtifactsPath)log/$(_BuildConfig)/
   - name: Build.Arcade.TestResultsPath
     value: $(Build.Arcade.ArtifactsPath)TestResults/$(_BuildConfig)/
 
-  # For full build we can do a shallow build, for a delta build we need the full history.
-  - ${{ if eq(variables['IsDeltaBuild'], 'true') }}:
-    - name: _FetchDepth
-      value: 0
-  - ${{ else }}:
-    - name: _FetchDepth
-      value: 1
-
   - ${{ if or(startswith(variables['Build.SourceBranch'], 'refs/heads/release/'), startswith(variables['Build.SourceBranch'], 'refs/heads/internal/release/'), eq(variables['Build.Reason'], 'Manual')) }}:
     - name: PostBuildSign
       value: false
@@ -163,7 +154,7 @@ stages:
           - checkout: self
             clean: true
             persistCredentials: true
-            fetchDepth: $(_FetchDepth)
+            fetchDepth: 1
 
         steps:
           - template: /eng/pipelines/templates/BuildAndTest.yml
@@ -173,7 +164,6 @@ stages:
               repoLogPath: $(Build.Arcade.LogsPath)
               repoTestResultsPath: $(Build.Arcade.TestResultsPath)
               skipQualityGates: ${{ eq(variables['SkipQualityGates'], 'true') }}
-              isDeltaBuild: $(IsDeltaBuild)
               isWindows: true
               warnAsError: 0
 
@@ -200,7 +190,7 @@ stages:
           - checkout: self
             clean: true
             persistCredentials: true
-            fetchDepth: $(_FetchDepth)
+            fetchDepth: 1
 
         steps:
           - template: /eng/pipelines/templates/BuildAndTest.yml
@@ -210,7 +200,6 @@ stages:
               repoLogPath: $(Build.Arcade.LogsPath)
               repoTestResultsPath: $(Build.Arcade.TestResultsPath)
               skipQualityGates: ${{ eq(variables['SkipQualityGates'], 'true') }}
-              isDeltaBuild: $(IsDeltaBuild)
               isWindows: false
               warnAsError: 0
 
@@ -262,8 +251,6 @@ stages:
           displayName: Init toolset
 
         - template: /eng/pipelines/templates/VerifyCoverageReport.yml
-          parameters:
-            isDeltaBuild: $(IsDeltaBuild)
 
 
 # ----------------------------------------------------------------
@@ -304,7 +291,7 @@ stages:
           - checkout: self
             clean: true
             persistCredentials: true
-            fetchDepth: $(_FetchDepth)
+            fetchDepth: 1
 
         steps:
           - template: \eng\pipelines\templates\BuildAndTest.yml
@@ -315,7 +302,6 @@ stages:
               repoTestResultsPath: $(Build.Arcade.TestResultsPath)
               skipTests: true
               skipQualityGates: true
-              isDeltaBuild: $(IsDeltaBuild)
               isWindows: false
 
 

bench/.editorconfig

@@ -1,5 +1,5 @@
 # Created by DiagConfig, the diagnostic config generator
-# Generated : 2023-08-07 17:59:53Z
+# Generated : 2023-10-22 00:37:47Z
 # Max Tier  : 2147483647
 # Attributes: general, performance
 # Analyzers : ILLink.RoslynAnalyzer, Microsoft.Analyzers.Extra, Microsoft.Analyzers.Local, Microsoft.AspNetCore.App.Analyzers, Microsoft.AspNetCore.Components.Analyzers, Microsoft.CodeAnalysis.CodeStyle, Microsoft.CodeAnalysis.CSharp.CodeStyle, Microsoft.CodeAnalysis.CSharp.NetAnalyzers, Microsoft.CodeAnalysis.NetAnalyzers, Microsoft.VisualStudio.Threading.Analyzers, Microsoft.VisualStudio.Threading.Analyzers.CSharp, SonarAnalyzer.CSharp, StyleCop.Analyzers
@@ -868,7 +868,7 @@ dotnet_diagnostic.CA1860.severity = warning
 # Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861
 dotnet_diagnostic.CA1861.severity = suggestion
 
-# Title    : Prefer using 'StringComparer' to perform case-insensitive string comparisons
+# Title    : Use the 'StringComparison' method overloads to perform case-insensitive string comparisons
 # Category : Performance
 # Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862
 dotnet_diagnostic.CA1862.severity = warning
@@ -903,6 +903,16 @@ dotnet_diagnostic.CA1867.severity = warning
 # Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1868
 dotnet_diagnostic.CA1868.severity = warning
 
+# Title    : Cache and reuse 'JsonSerializerOptions' instances
+# Category : Performance
+# Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869
+dotnet_diagnostic.CA1869.severity = warning
+
+# Title    : Use a cached 'SearchValues' instance
+# Category : Performance
+# Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1870
+dotnet_diagnostic.CA1870.severity = warning
+
 # Title    : Dispose objects before losing scope
 # Category : Reliability
 # Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000
@@ -1720,62 +1730,77 @@ dotnet_diagnostic.CA5405.severity = none
 
 # Title    : Use source generated logging methods for improved performance
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0000
 dotnet_diagnostic.EA0000.severity = warning
 
 # Title    : Perform message formatting in the body of the logging method
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0001
 dotnet_diagnostic.EA0001.severity = warning
 
 # Title    : Use 'System.TimeProvider' to make the code easier to test
 # Category : Reliability
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0002
 dotnet_diagnostic.EA0002.severity = none
 
 # Title    : Use the character-based overloads of 'String.StartsWith' or 'String.EndsWith'
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0003
 dotnet_diagnostic.EA0003.severity = warning
 
 # Title    : Make types declared in an executable internal
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0004
 dotnet_diagnostic.EA0004.severity = warning
 
 # Title    : Consider using an array instead of a collection
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0005
 dotnet_diagnostic.EA0005.severity = none
 
 # Title    : Replace uses of 'Enum.GetName' and 'Enum.ToString' for improved performance
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0006
 dotnet_diagnostic.EA0006.severity = warning
 
 # Title    : Use 'System.ValueTuple' instead of 'System.Tuple' for improved performance
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0007
 dotnet_diagnostic.EA0007.severity = warning
 
 # Title    : Use generic collections instead of legacy collections for improved performance
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0008
 dotnet_diagnostic.EA0008.severity = warning
 
 # Title    : Use 'System.MemoryExtensions.Split' for improved performance
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0009
 dotnet_diagnostic.EA0009.severity = warning
 
 # Title    : Fire-and-forget async call inside a 'using' block
 # Category : Correctness
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0010
 dotnet_diagnostic.EA0010.severity = warning
 
 # Title    : Consider removing unnecessary conditional access operator (?)
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0011
 dotnet_diagnostic.EA0011.severity = warning
 
 # Title    : Consider removing unnecessary null coalescing assignment (??=)
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0012
 dotnet_diagnostic.EA0012.severity = suggestion
 
 # Title    : Consider removing unnecessary null coalescing operator (??)
 # Category : Performance
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0013
 dotnet_diagnostic.EA0013.severity = suggestion
 
 # Title    : The async method doesn't support cancellation
 # Category : Resilience
+# Help Link: https://aka.ms/dotnet-extensions-warnings/EA0014
 dotnet_diagnostic.EA0014.severity = none
 
 # Title    : Set MSBuild property 'GenerateDocumentationFile' to 'true'
@@ -2408,6 +2433,26 @@ dotnet_diagnostic.IDE0300.severity = none
 # Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0301
 dotnet_diagnostic.IDE0301.severity = suggestion
 
+# Title    : Simplify collection initialization
+# Category : Style
+# Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0302
+dotnet_diagnostic.IDE0302.severity = none
+
+# Title    : Simplify collection initialization
+# Category : Style
+# Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0303
+dotnet_diagnostic.IDE0303.severity = none
+
+# Title    : Simplify collection initialization
+# Category : Style
+# Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0304
+dotnet_diagnostic.IDE0304.severity = none
+
+# Title    : Simplify collection initialization
+# Category : Style
+# Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0305
+dotnet_diagnostic.IDE0305.severity = none
+
 # Title    : Delegate invocation can be simplified.
 # Category : Style
 # Help Link: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide1005