Skip to content

Add Microsoft.Extensions.Compliance.Testing readme #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

Add Microsoft.Extensions.Compliance.Testing readme #4660

merged 1 commit into from
Nov 6, 2023

Conversation

@sebastienros
Copy link
Member

@sebastienros sebastienros commented Nov 2, 2023 •
edited by ghost
Loading

null

Microsoft Reviewers: Open in CodeFlow

@sebastienros sebastienros requested a review from geeknoid November 2, 2023 20:00
@ghost ghost assigned sebastienros Nov 2, 2023
@dotnet-comment-bot
Copy link
Collaborator

dotnet-comment-bot commented Nov 2, 2023

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Telemetry 92 93
Microsoft.AspNetCore.Diagnostics.Middleware 99 100
Microsoft.Extensions.Diagnostics.ResourceMonitoring 98 100

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=458835&view=codecoverage-tab

joperezr
joperezr approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RussKie
Copy link
Contributor

RussKie commented Nov 2, 2023

🎉 Good job! The coverage increased 🎉 Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Telemetry 92 93
Microsoft.AspNetCore.Diagnostics.Middleware 99 100
Microsoft.Extensions.Diagnostics.ResourceMonitoring 98 100
Full code coverage report: dev.azure.com/dnceng-public/public/_build/results?buildId=458835&view=codecoverage-tab

Could you update these as well?

@RussKie RussKie added the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Nov 2, 2023
@joperezr
Copy link
Member

joperezr commented Nov 3, 2023

🎉 Good job! The coverage increased 🎉 Update MinCodeCoverage in the project files.
Project Expected Actual
Microsoft.Extensions.Telemetry 92 93
Microsoft.AspNetCore.Diagnostics.Middleware 99 100
Microsoft.Extensions.Diagnostics.ResourceMonitoring 98 100
Full code coverage report: dev.azure.com/dnceng-public/public/_build/results?buildId=458835&view=codecoverage-tab

Could you update these as well?

We should probably do a separate PR for that. Just my 2 cents.

@joperezr joperezr merged commit 9921fb5 into release/8.0 Nov 6, 2023
@joperezr joperezr deleted the sebros/compliancetesting branch November 6, 2023 18:39
@ghost ghost removed the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Nov 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joperezr joperezr joperezr approved these changes

@geeknoid geeknoid Awaiting requested review from geeknoid

Assignees

@sebastienros sebastienros

Labels

area-infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebastienros @dotnet-comment-bot @RussKie @joperezr