Skip to content

Redaction improvements. #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

Redaction improvements. #4516

merged 1 commit into from
Oct 18, 2023

Conversation

@geeknoid
Copy link
Member

@geeknoid geeknoid commented Oct 5, 2023 •
edited
Loading

  • Add the HMAC redactor.

  • Add support for discriminating redacted values. The discriminator is derived from the name of the item being redacted.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned geeknoid Oct 5, 2023
@geeknoid geeknoid force-pushed the geeknoid/redaction branch 2 times, most recently from c5af39f to 9303bf6 Compare October 5, 2023 13:16
@joperezr joperezr mentioned this pull request Oct 6, 2023
Closed
@geeknoid geeknoid force-pushed the geeknoid/redaction branch 4 times, most recently from c354b96 to 63b5af9 Compare October 17, 2023 16:11
xakep139
xakep139 reviewed Oct 17, 2023
View reviewed changes
@geeknoid geeknoid force-pushed the geeknoid/redaction branch 2 times, most recently from 4f8acb2 to 1f86a90 Compare October 17, 2023 17:24
@geeknoid geeknoid force-pushed the geeknoid/redaction branch 2 times, most recently from f85dac8 to 1de5b94 Compare October 18, 2023 12:02
xakep139
xakep139 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@xakep139 xakep139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but overall looks good to me

@geeknoid geeknoid force-pushed the geeknoid/redaction branch 3 times, most recently from 96c48f4 to 440dc57 Compare October 18, 2023 17:41
Redaction improvements.
f6e5732 
- Add the HMAC redactor.

- Add support for salting redacted values. The salt
is derived from the name of the item being redacted, and
can optionally include the current day of the year (which
induces daily rotation).

- Delete the xxHash3 redactor.
@geeknoid geeknoid merged commit eca8bd0 into release/8.0 Oct 18, 2023
@geeknoid geeknoid deleted the geeknoid/redaction branch October 18, 2023 19:35
@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@xakep139 xakep139 xakep139 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@geeknoid geeknoid

Labels

area-telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@geeknoid @xakep139