Increased the max supported dimensions via source gen to 30 dimensions #4580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions via source-gen to 30 dimensions
ghost
assigned
xakep139
reviewed
Oct 18, 2023
Member
|
Does this code still have the quirk where it counts properties with nested classes as dimensions themselves? IIRC it wasn't resolved internally either. It seems counter-intuitive behavior, so we should probably document it somewhere or fix it. |
xakep139
reviewed
Oct 18, 2023
dariusclay
reviewed
Oct 18, 2023
xakep139
reviewed
Oct 18, 2023
src/Generators/Microsoft.Gen.Metrics/StrongTypeAttributeParameters.cs
Outdated
Show resolved
Hide resolved
added 3 commits
October 18, 2023 11:39
…pported_dimensions_via_source_gen_to_30_dimensions' of https://github.com/tekian/extensions into commit_a0d6364e__merged_pr_801011__increased_the_max_supported_dimensions_via_source_gen_to_30_dimensions
xakep139
approved these changes
Oct 18, 2023
dariusclay
approved these changes
Oct 18, 2023
geeknoid
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions via source-gen to 30 dimensions
Microsoft Reviewers: Open in CodeFlow