-
Notifications
You must be signed in to change notification settings - Fork 841
Revamp data classification model. #4593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa94de3 to
152b49e
Compare
danmoseley
reviewed
Oct 21, 2023
src/Libraries/Microsoft.Extensions.Compliance.Abstractions/Classification/DataClassification.cs
Outdated
Show resolved
Hide resolved
- Introduce the DataClassificationSet type that represents a set of combined classifications. This replaces the previous ability to OR together multiple classifications, which was too constraining.
778a682 to
2fc1450
Compare
xakep139
reviewed
Oct 22, 2023
...braries/Microsoft.Extensions.Compliance.Abstractions/Classification/DataClassificationSet.cs
Show resolved
Hide resolved
xakep139
reviewed
Oct 22, 2023
...braries/Microsoft.Extensions.Compliance.Abstractions/Classification/DataClassificationSet.cs
Show resolved
Hide resolved
src/Generators/Microsoft.Gen.Logging/Emission/Emitter.Method.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Compliance.Abstractions/Classification/DataClassification.cs
Outdated
Show resolved
Hide resolved
...braries/Microsoft.Extensions.Compliance.Abstractions/Classification/DataClassificationSet.cs
Outdated
Show resolved
Hide resolved
dariusclay
approved these changes
Oct 26, 2023
Member
dariusclay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4493
Microsoft Reviewers: Open in CodeFlow