Hosting.Testing readme #4556
Merged
Hosting.Testing readme #4556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joperezr
reviewed
Oct 12, 2023
joperezr
reviewed
Oct 12, 2023
src/Libraries/Microsoft.Extensions.Hosting.Testing/FakeHostOptions.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Oct 12, 2023
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
Other than making sure the Experimental attributes are right, this LGTM.
geeknoid
approved these changes
Oct 16, 2023
Member
geeknoid
left a comment
geeknoid
left a comment
There was a problem hiding this comment.
Just remove the changes to the .cs files please, those aren't needed.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
danmoseley
reviewed
Oct 17, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Microsoft Reviewers: Open in CodeFlow