4.0 dev #41
Merged
4.0 dev #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joomla! 3.9.8 release
[4.0] 3.9.7 and 3.9.8 merge
Joomla! 3.9.10
Joomla 3.9.10 merge
Joomla! 3.9.11
Remove description element from repeatable xml merged in error by @wilsonge
Joomla 3.9.11 merge
* Reame presets for main menu: default and alternate instead of joomla and modern * fix typo
The actions button on the stages and transitions pages is using the wrong icon and class
The colour used for the warnings is far too close to the error colour. This PR changes it back to the yellow colour bootstrap intended and changes the text to black from white to satisfy accessibility - just as bootstrap does
We can never have any value for autocomplete in the xml other than 'off' You can see this by changing the value for autocomplete here to anything else and instead of the autocomplete being output with the new value it is removed. https://github.com/joomla/joomla-cms/blob/bc42bb1e43d96334c38222dbe49b83f898413f2a/administrator/components/com_users/forms/user.xml#L20-L30 Autocomplete has a lot of useful values that we could/should be using see https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete For example `autocomplete=off` really doesn't do anything on password fields. Instead we should be using `autocomplete="new-password"` And autocomplete is not the same as autofill > Chrome will still respect this tag for autocomplete data, it will not respect it for autofill data
This PR adjust the column widths slightly but more importantly it applies the cell class to all cells not just the ones in the header. The real easy way to test this PR is to open the mail templates list view on a mobile (or emulator)
During the installation process if you have selected to install languages but don't select any and click next then you will see this error message. > No languages have been selected to be installed. If you need to install more languages, press the 'Previous' button and choose the desired languages from the list." As there is no previous button and you are still on the page with the list of langauges it is sufficient to say > No languages have been selected to be installed.
Use a mail template specific message
Sort by created did not work - it was sorting by id To test you will need to enable the "Detect" mode in the com_csp options and browse a few pages in the admin to gather some data cc / @zero-24
Gave some love to the mobile view for this component hidden-phone and nowrap are classes that are not present in J4 reduced the number of columns displayed
It is a button not an icon
Gave some love to the mobile view for the list of users Before the PR the columns displayed were name and usergroup but without the usergrup column header After the PR the columns displayed are name, and active and blocked status
Gave some love to the mobile view for the list of contacts Removed the linked user column
It is not possible for a csp report to be archived. This PR removes the archive option from the filter state options //cc @zero-24
…llable datetime columns (#26372)
The button had the wrong class and therefore the wrong colour
You cant just "hide" the cells in the table body you haave to hide the cells in the table header as well To test you will need to enable the "Detect" mode in the com_csp options and browse a few pages in the admin to gather some data cc / @zero-24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
23 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required