Skip to content

Conversation

@Quy
Copy link
Contributor

@Quy Quy commented Aug 28, 2019

Summary of Changes

Check for target value and to not output if empty.

Testing Instructions

In back end, go to System.
View page source.
Find target="" (31 instances)

Go to Help.
Find target="" (2 instances)
Note the other links have target="_blank".

Expected result

No target=""

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 1dbb48d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26060.

@uGE70
Copy link

uGE70 commented Aug 28, 2019

I have tested this item ✅ successfully on 1dbb48d

After patch applied, all target="" have been removed from System and Help pages.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26060.

@Quy Quy removed the PR-4.0-dev label Aug 28, 2019
@Quy
Copy link
Contributor Author

Quy commented Aug 28, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26060.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 28, 2019
@ghost ghost added the PR-4.0-dev label Aug 29, 2019
@wilsonge wilsonge merged commit 7799c77 into joomla:4.0-dev Sep 2, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Sep 2, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 2, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 2, 2019
@Quy Quy deleted the remove-target branch September 2, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants