Skip to content

Conversation

@brianteeman
Copy link
Contributor

Removes the redundant word "show" from the language strings. It's a select field so we can assume it means show. We don't say "show" anywhere else

before

image

after

image

Removes the redundant word "show" from the language strings. It's a select field so we can assume it means show. We don't say "show" anywhere else
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Sep 1, 2019
@Quy
Copy link
Contributor

Quy commented Sep 2, 2019

For the Featured select type, Articles is proper case. Should extensions be too?

- Select Featured - 
Unfeatured Articles 
Featured Articles

@Quy
Copy link
Contributor

Quy commented Sep 2, 2019

I have tested this item ✅ successfully on 75ad478


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26126.

@HLeithner
Copy link
Member

Is "- select core -" correct ? shouldn't it be somthing like "select type"? At least I wouldn't understand out of context what "select core" means.

@brianteeman
Copy link
Contributor Author

I wasn't happy with it either but I don't think type is any better and I can't think of anything better

@ghost
Copy link

ghost commented Sep 2, 2019

– Select Extensions –
Core extensions
Non-core extensions

@brianteeman
Copy link
Contributor Author

I will go with @franz-wohlkoenig suggestion and then hopefully this can be merged

@HLeithner
Copy link
Member

Still not perfect but better then "core". Thanks.

@HLeithner HLeithner merged commit 4a6cfbd into joomla:4.0-dev Sep 2, 2019
@HLeithner HLeithner added this to the Joomla 4.0 milestone Sep 2, 2019
@brianteeman
Copy link
Contributor Author

small steps

thanks for merging

@brianteeman brianteeman deleted the sxm36 branch September 2, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants