Skip to content

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Oct 7, 2019

Summary of Changes

fix PHP Notice: Undefined variable: db in administrator/components/com_banners/Table/BannerTable.php on line 324

Testing Instructions

create a banner
set it pinned unpinned
check error log

Expected result

no notice

Actual result

notice

@Quy
Copy link
Contributor

Quy commented Oct 7, 2019

I have tested this item ✅ successfully on 4b1ffab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26512.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 4b1ffab

It took a while until I noticed you meant pin/unpin in the list view and not in the edit view ;-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26512.

@Quy Quy removed the PR-4.0-dev label Oct 7, 2019
@Quy
Copy link
Contributor

Quy commented Oct 7, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26512.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 7, 2019
@wilsonge wilsonge merged commit 9738526 into joomla:4.0-dev Oct 7, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Oct 7, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 7, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 7, 2019
@alikon alikon deleted the patch-117 branch October 21, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants