Skip to content

Conversation

@brianteeman
Copy link
Contributor

This PR adjust the column widths slightly but more importantly it applies the cell class to all cells not just the ones in the header. (Otherwise what happens is that the column headers are hidden on mobile but the column data is still displayed

The real easy way to test this PR is to open the mail templates list view on a mobile (or emulator)

You might find it helpful when testing to create some dummy records in #__mail_templates with fields of various length text strings - but not essential to do this.

Before and After mobile views

image
image

Pull Request for Issue # .

This PR adjust the column widths slightly but more importantly it applies the cell class to all cells not just the ones in the header.

The real easy way to test this PR is to open the mail templates list view on a mobile (or emulator)

### Before

### After
@wilsonge wilsonge merged commit b05b378 into joomla:4.0-dev Oct 6, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Oct 6, 2019

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 6, 2019
@brianteeman
Copy link
Contributor Author

Thanks for the quick merge

@brianteeman brianteeman deleted the mail5 branch October 6, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants