Skip to content

Conversation

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Oct 5, 2019

Pull Request for Issue # .

Summary of Changes

Replaces JOIN and GROUP clauses in query with a subquery for improved performance.

Testing Instructions

Set up a multilingual site.
Enable language associations.
Create some contacts with and without associations
View contact list in backend.

Expected result

Works like before.

Documentation Changes Required

No.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 399b681

Tested with MySQL 5.7 and PostgreSQL 10.10.

About performance I can't say anything because my test data set is too small.

But I can confirm everything works as well as before, carefully watching PHP error log with PHP error reporting set to maximum and watching database log.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26482.

@alikon
Copy link
Contributor

alikon commented Oct 6, 2019

I have tested this item ✅ successfully on 399b681


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26482.

@alikon
Copy link
Contributor

alikon commented Oct 6, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26482.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed PR-4.0-dev labels Oct 6, 2019
@wilsonge wilsonge merged commit 24ad38f into joomla:4.0-dev Oct 6, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Oct 6, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Oct 6, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants