[4.0] Warning colour #26124
Merged
[4.0] Warning colour #26124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The colour used for the warnings is far too close to the error colour. This PR changes it back to the yellow colour bootstrap intended and changes the text to black from white to satisfy accessibility - just as bootstrap does
Closed
|
I have tested this item ✅ successfully on f7070f1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26124. |
|
Thanks! |
|
thanks - my eyes wont hurt anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colour used for the warnings is far too close to the error colour.
warning
error
This PR changes it back to the yellow colour bootstrap intended and changes the text to black from white to satisfy accessibility - just as bootstrap does
And it is pretty weird to have a variable called yellow being a dark orange ;)
Pull Request for Issue #25911
Testing Instructions
Apply PR and then npm i
on a non multilingual site visit the multilingual associations page
Before
After
and the information warnings page
Before
After