Skip to content

Conversation

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Oct 4, 2019

Summary of Changes

This ports changes from #19284 to backend article list view.

Testing Instructions

Create some articles with tags.
View article list in backend.
Filter articles by single and multiple tags.

Expected result

Works like before.

Documentation Changes Required

No.

@richard67
Copy link
Member

@SharkyKZ Here drone is failing because of PHPCS, not because of unrelated stuff like elsewhere.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 532c189

Tested with MySQL 5.7 and PostgreSQL 10.10.

About performance I can't say anything because my test data set is too small.

But I can confirm everything works as well as before, carefully watching PHP error log with PHP error reporting set to maximum and watching database log.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26466.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 4f40d07

Tested with MySQL 5.7 and PostgreSQL 10.10.

About performance I can't say anything because my test data set is too small.

But I can confirm everything works as well as before, carefully watching PHP error log with PHP error reporting set to maximum and watching database log.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26466.

@alikon
Copy link
Contributor

alikon commented Oct 5, 2019

I have tested this item ✅ successfully on 4f40d07


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26466.

@alikon
Copy link
Contributor

alikon commented Oct 5, 2019

RTD


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26466.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 5, 2019
@wilsonge wilsonge merged commit fec664b into joomla:4.0-dev Oct 6, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Oct 6, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 6, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants