Skip to content

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Aug 30, 2019

Pull Request for Issue #26067

Summary of Changes

The names of presets for main menu have been changed

Testing Instructions

In Modules, open the admini module "admin menu" and change the preset.

Expected result

Everything works as before

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Aug 30, 2019
@infograf768
Copy link
Member

I guess we have to add in script the deletion of the older joomla and modern presets.
Looks like changing file names is not really understood by git which consider it is a conflict.

@infograf768
Copy link
Member

I test this OK btw if the so-called conflicts can be solved.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 733d823


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26084.

1 similar comment
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 733d823


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26084.

@infograf768
Copy link
Member

RTC if conflicts can be solved

@zero-24 @HLeithner @wilsonge


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26084.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 30, 2019
@zero-24
Copy link
Contributor

zero-24 commented Aug 30, 2019

Yes already on my list.

@zero-24
Copy link
Contributor

zero-24 commented Aug 30, 2019

merge conflict has been resolved

@infograf768
Copy link
Member

Restarted drone

@infograf768
Copy link
Member

@wilsonge @HLeithner
Please merge so that we can improve the alternate xml

@infograf768 infograf768 merged commit 6e3c348 into joomla:4.0-dev Sep 1, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 1, 2019
@infograf768
Copy link
Member

Thanks!

@chmst chmst deleted the Rename-presets branch October 5, 2019 09:04
@Quy Quy added this to the Joomla 4.0 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants