[MINOR] ui improvement #1517
Closed
[MINOR] ui improvement #1517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2016 15:07
Member
|
LGTM. It's simple and clean. :-) |
Contributor
|
Looks good to me |
Contributor
|
Change looks great to me, that you for your contribution. |
Contributor
|
@baekhoseok Thanks for your contribution and looks nice to me! Probably it's a nitpick, how about keeping consistency for that two buttons in interpreter setting page? Here are two suggestions. 1. Icons with tooltips and no button border
2. Icons with button border and no tooltip
What do you think? :) |
### What is this PR for? Based on #338 , I refactor most of pig interpreter. As I don't think the approach in #338 is the best approach. In #338, we use script `bin/pig` to launch pig script, it is different to control that job (hard to kill and get progress and stats info). In this PR, I use pig api to launch pig script. Besides that I implement another interpreter type `%pig.query` to leverage the display system of zeppelin. For the details you can check `pig.md` ### What type of PR is it? [Feature] ### Todos * Syntax Highlight * new interpreter type `%pig.udf`, so that user can write pig udf in zeppelin directly and don't need to build udf jar manually. ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-335 ### How should this be tested? Unit test is added and also manual test is done ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Author: Ali Bajwa <[email protected]> Author: AhyoungRyu <[email protected]> Author: Jeff Zhang <[email protected]> Closes #1476 from zjffdu/ZEPPELIN-335 and squashes the following commits: 73a07f0 [Jeff Zhang] minor update a1b742b [Jeff Zhang] minor update on doc e858301 [Jeff Zhang] address comments c85a090 [Jeff Zhang] add license 58b4b2f [Jeff Zhang] minor update of docs 1ae7db2 [Jeff Zhang] Merge pull request #2 from AhyoungRyu/ZEPPELIN-335/docs fe014a7 [AhyoungRyu] Fix docs title in front matter df7a6db [AhyoungRyu] Add pig.md to dropdown menu 5e2e222 [AhyoungRyu] Minor update for pig.md 39f161a [Jeff Zhang] address comments 05a3b9b [Jeff Zhang] add pig.md a09a7f7 [Jeff Zhang] refactor pig Interpreter c28beb5 [Ali Bajwa] Updated based on comments: 1. Documentation: added pig.md with interpreter documentation and added pig entry to index.md 2. Added test junit test based on passwd file parsing example here https://pig.apache.org/docs/r0.10.0/start.html#run 3. Removed author tag from comment (this was copied from shell interpreter https://github.com/apache/incubator-zeppelin/blob/master/shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java#L42) 4. Implemented cancel functionality 5. Display output stream in case of error 2586336 [Ali Bajwa] exposed timeout and pig executable via interpreter and added comments 7abad20 [Ali Bajwa] initial commit of pig interpreter
### What is this PR for? Fix input form placeholder for `note url` ### What type of PR is it? Improvement ### Todos * [x] - Task ### What is the Jira issue? [ZEPPELIN-1540](https://issues.apache.org/jira/browse/ZEPPELIN-1540) ### How should this be tested? go to import note menu -> add from url -> see input forms ### Screenshots (if appropriate) Before: <img width="593" alt="screen shot 2016-10-13 at 2 37 24 pm" src="https://cloud.githubusercontent.com/assets/1642088/19337731/9ea41248-9152-11e6-859b-757f44b2866a.png"> After: <img width="601" alt="screen shot 2016-10-13 at 2 36 06 pm" src="https://cloud.githubusercontent.com/assets/1642088/19337716/7f90522c-9152-11e6-8ad2-cbfcdc241e10.png"> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <[email protected]> Closes #1509 from khalidhuseynov/fix/note-import-placeholder and squashes the following commits: c01b982 [Khalid Huseynov] note name -> note url
### What is this PR for? fixed 'add from URL' button and disable backdrop function. ### What type of PR is it? Bug Fix ### Todos None ### What is the Jira issue? [ZEPPELIN-1550](https://issues.apache.org/jira/browse/ZEPPELIN-1550) ### How should this be tested? click 'Import note' -> click 'Add from URL' -> click 'x' button -> open the dialog again -> it shows the URL page not the initial page. ### Screenshots (if appropriate) - before  - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Yunho Maeng <[email protected]> Closes #1523 from yunho0130/ZEPPELIN-1550 and squashes the following commits: a045928 [Yunho Maeng] fixed 'add from URL' button and disable backdrop fuction when user use modal window
…shortens. ### What is this PR for? In document page(http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/), the search button goes to next line when display's width shortens. ### What type of PR is it? [Improvement] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1552 ### Screenshots (if appropriate) <img width="927" alt="2016-10-15 2 04 00" src="https://cloud.githubusercontent.com/assets/6567102/19398321/0d76a1c4-9287-11e6-86e0-9f120c00b143.png"> when (768px ≤ width < 992px) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: hyonzin <[email protected]> Author: AhyoungRyu <[email protected]> Author: 정현진 <[email protected]> Closes #1525 from hyonzin/ZEPPELIN-1552 and squashes the following commits: f1d97ef [AhyoungRyu] Fix search icon's placement in small browser 244992d [정현진] Straighten wrong term 97d1bdf [hyonzin] Fix search link button to not goes next line when display's width shortens
### What is this PR for? Applying for new registration mechanism for Apache Kylin ### What type of PR is it? [Feature] ### Todos * [x] - Added interpreter-setting.json ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-916 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <[email protected]> Closes #1515 from jongyoul/ZEPPELIN-916 and squashes the following commits: 5e23043 [Jongyoul Lee] Added interpreter-setting.json Fixed test environments
…erpreters ### What is this PR for? See #1439. This is a second attempt based on prior feedback, particularly from Leemoonsoo who advised that it would be better to contain all of the code inside of the Interpreter Process. Aside from this, the major changes since the previous PR are: - The terminology "hooks" is used instead of "callbacks". Since the information being passed to the interpreter isn't actually a "callback", strictly speaking, the more general term "hook" is probably a better choice. All variable / class names were updated correspondingly. - The registry is now keyed by class name rather than the `replName` specified by the magic on top of the paragraph. The interface provided by `ZeppelinContext` allows for a `replName` to be converted to `className` through an internal mapping. - Two new event codes, `PRE_EXEC_DEV` and `POST_EXEC_DEV` have been added. This is primarily intended to separate use cases for the interpreter maintainers (via subclasses of `Interpreter`) and the notebook users (via the `ZeppelinContext` class), as otherwise user attempts at registering a hook would overwrite that set by the interpreter maintainer. - Global scope for hook registration is supported for the developer use cases. ### What type of PR is it? New Feature ### What is the Jira issue? [ZEPPELIN-1423](https://issues.apache.org/jira/browse/ZEPPELIN-1423) ### How should this be tested? In a new note, add the following lines of code to a paragraph: ```python %pyspark z.registerHook("post_exec", "print 'This code should be executed before the paragraph code!'") z.registerHook("pre_exec", "print 'This code should be executed after the paragraph code!'") ``` Then run any other paragraph in the note containing some other code, eg ```python %pyspark print "This code should be entered into the paragraph by the user!" ``` The output should be: ``` This code should be executed before the paragraph code! This code should be entered into the paragraph by the user! This code should be executed after the paragraph code! ``` You should also test out the other two methods (`getCallback()` and `unregisterCallback()`) specified in `ZeppelinContext.java`. One final caveat that should be mentioned: If there are errors in the code you specify for a pre-execute event, it will render the interpreter useless since the current implementation prepends the the code specified in `pre_exec` directly to the paragraph entered code before calling `interpret()`. The current workaround for this would be to either restart the interpreter group or call `unregisterHook()` via a different REPL within the interpreter group (eg, `z.unregisterHook("pre_exec", "pyspark")` from the spark interpreter). I would appreciate if anyone here would be willing to share any better approaches here. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes Author: Alex Goodman <[email protected]> Closes #1470 from agoodm/ZEPPELIN-1423v2 and squashes the following commits: 56ede60 [Alex Goodman] Automatically detect default interpreter for registerHook() 044a99d [Alex Goodman] Ensure that registered hooks are applied after call to open() 1331fe1 [Alex Goodman] Update interpreters.md 07cac65 [Alex Goodman] Implemented user-defined hook registry system for spark/pyspark interpreters 8fad936 [Alex Goodman] Added Interpreter Hooks to Interpreter Process
… incompatible license ### What is this PR for? According to https://developers.arcgis.com/terms/ and and http://www.esri.com/legal/software-license, current map visualization depends on an online service that has incompatible restrictions to Apache 2 license. Please see #1210 (comment) Possible alternative way is explained [here](#1210 (comment)). I'm very sad to remove this very good contribution. So please anyone review the license and comment here if you have other opinions, or other way around. ### What type of PR is it? [Task] ### Todos * [x] - remove implementation from source tree ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1532 ### Questions: * Does the licenses files need update? yes * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #1501 from Leemoonsoo/ZEPPELIN-1532 and squashes the following commits: b5ad91a [Lee moon soo] Remove map visualization dad81c4 [Lee moon soo] Remove map visualization from source tree
### What is this PR for? Graceful handling of errors in storage sync layer ### What type of PR is it? Bug Fix | Improvement ### Todos * [x] - catch and continue ### What is the Jira issue? [ZEPPELIN-1557](https://issues.apache.org/jira/browse/ZEPPELIN-1557) ### How should this be tested? green CI ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <[email protected]> Closes #1532 from khalidhuseynov/fix/storage-graceful-sync and squashes the following commits: d036d9e [Khalid Huseynov] catch exception, log, and continue
…broadcast ### What is this PR for? This PR addresses part of multi-user note management in Zeppelin. One of the tasks namely listing notes per user on Zeppelin start was addressed in #1330. However that PR didn't solve all problems, and reloading notes was incomplete as well as socket broadcast was not user aware [ZEPPELIN-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437), [ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438). This PR addresses those issue. ### What type of PR is it? Improvement ### Todos * [x] - list notes per user on reload * [x] - broadcast per user (multicast) * [x] - tests * [x] - use authorization module to filter notes on sync * [x] - broadcast on permissions change * [ ] - discussion and review ### What is the Jira issue? [Zeppelin-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437), [ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438) ### How should this be tested? 1. Start Zeppelin 2. Login as user1, and user2 on different windows 3. Each user should be able to see their own note workbench 4. If note changed to private (readers, writers not empty), that note should disappear from others note workbench. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? yes Author: Khalid Huseynov <[email protected]> Closes #1392 from khalidhuseynov/feat/multi-user-notes and squashes the following commits: a2ce268 [Khalid Huseynov] broadcast note list on perm update - zeppelin-1438 9cf1d88 [Khalid Huseynov] fix init not to initialize every time 17eae84 [Khalid Huseynov] bugfix: add precondition for NP 781207e [Khalid Huseynov] bugfix: reload only once 537cc0e [Khalid Huseynov] apply filter from authorization in sync 09e6723 [Khalid Huseynov] notebookAuthorization as singleton 9427e62 [Khalid Huseynov] multicast fine grained note lists to users instead of broadcast 6614e2b [Khalid Huseynov] improve tests 1399407 [Khalid Huseynov] remove unused imports d9c3bc9 [Khalid Huseynov] filter reload using predicates 92f37f5 [Khalid Huseynov] substitute old getAllNotes(subject) with new implementation b7f19c9 [Khalid Huseynov] separate getAllNotes() and getAllNotes(subject) 17e2d4c [Khalid Huseynov] first draft
### What is this PR for? This is to resolve possible NPEs in storage mechanism related to empty subject ### What type of PR is it? Bug Fix ### Todos * [x] - pass `subject` instead of `null` ### What is the Jira issue? [ZEPPELIN-1487](https://issues.apache.org/jira/browse/ZEPPELIN-1487) ### How should this be tested? storage tests pass, CI green ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <[email protected]> Closes #1459 from khalidhuseynov/fix/storage-npe and squashes the following commits: 1f2dcd3 [Khalid Huseynov] pass subject to get method in sync
…-server, zeppelin-zengine ### What is this PR for? While running jUnit tests in zeppelin-server & zeppelin-zengine projects, several note are created during the process and those notes are never purged after the execution of the tests. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1542 ### How should this be tested? Prerequisites: 1. Get the list of note that already exist in server. Now build zeppelin project by running maven commands(mvn clean package)(mvn clean package -pl 'zeppelin-interpreter,zeppelin-zengine,zeppelin-server'). 1. Now no extra note should get created after running the maven command ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: rajarajan-g <[email protected]> Closes #1524 from rajarajan-g/ZEPPELIN-1542 and squashes the following commits: d97cb4a [rajarajan-g] code changes for ZEPPELIN-1542
…terpreter. ### What is this PR for? This PR fixes dependency library loading bug when creating new interpreter. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1534 ### How should this be tested? 1. Create new JDBC interpreter refer to http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/jdbc.html#mysql. 2. Create new paragraph for testing new JDBC interpreter. 3. Run paragraph. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <[email protected]> Closes #1507 from astroshim/ZEPPELIN-1534 and squashes the following commits: aebe352 [astroshim] add loadInterpreterDependencies function in createNewSetting()
### What is this PR for? The result of an aggregation query returned by the interpreter contains only "key" and "doc_count" in case of a multi-buckets aggregations. But the result returned by Elasticsearch can contain more data according to the query. This PR is an improvement of the result returned by the interpreter. ### What type of PR is it? [Improvement] ### Todos * [X] - Dev of the improvement in the interpreter * [X] - Add a test case ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1537 ### How should this be tested? In a paragraph, enter a query with multiple aggregations: search /logs { "aggs" : { "length" : { "terms": { "field": "status" }, "aggs" : { "sum_length" : { "sum" : { "field" : "content_length" } } } } } ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Bruno Bonnin <[email protected]> Closes #1508 from bbonnin/master and squashes the following commits: a0a7bb9 [Bruno Bonnin] Elasticsearch improvement for results of aggregations
This PR replaces #1309 Author: Chris Snow <[email protected]> Closes #1531 from snowch/snowch-patch-1 and squashes the following commits: f5f7a70 [Chris Snow] use toString() method of CommandLine for logging 09a6d23 [Chris Snow] added missing semi-colon for statement 25e8a29 [Chris Snow] [ZEPPELIN-1314] dump out the R command
### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: LantaoJin <[email protected]> Closes #1511 from LantaoJin/master and squashes the following commits: 671cd68 [LantaoJin] keep old py4j for backward compatibility 3bd84cc [LantaoJin] [ZEPPELIN-1544]upgrade spark version to 2.0.1 as profile spark-2.0
…tebooks ### What is this PR for? Currently, if you have a Notebook large number of, There is a sharp decrease in performance of the Code editor. The number and Paragraph creation of the Notebook does not have a relationship. We are should always use the Code editor of the same performance. I had to print a Notebook list only if there is a request. There was quite a lot of performance improvements. ### What type of PR is it? Improvement ### Todos - [x] - change Notebook list render logic ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1559 https://issues.apache.org/jira/browse/ZEPPELIN-1513 ### How should this be tested? 1. Create a notebook over 1000. (tested 10,000) I've used script on this. (important! please, backup for notebooks directory.) ``` #/bin/bash idx="0" while [ $idx -lt 1000 ] # notebooks count 1000 do mkdir $idx echo """ { \"paragraphs\": [ { \"text\": \"fsdkljfowiejfowejfoiwefiowejfiojlkdsjfklsdjflkjsdflkjwlkjefewf\", \"dateUpdated\": \"Oct 13, 2016 5:02:44 PM\", \"config\": { \"colWidth\": 12.0, \"graph\": { \"mode\": \"table\", \"height\": 300.0, \"optionOpen\": false, \"keys\": [], \"values\": [], \"groups\": [], \"scatter\": {}, \"map\": { \"baseMapType\": \"Streets\", \"isOnline\": true, \"pinCols\": [] } }, \"enabled\": true, \"editorMode\": \"ace/mode/scala\" }, \"settings\": { \"params\": {}, \"forms\": {} }, \"apps\": [], \"jobName\": \"paragraph_1476345687682_-1459653828\", \"id\": \"20161013-170127_68316618\", \"dateCreated\": \"Oct 13, 2016 5:01:27 PM\", \"status\": \"READY\", \"progressUpdateIntervalMs\": 500 } ], \"name\": \""${idx}"\", \"id\": \""${idx}"\", \"angularObjects\": { \"2BZSC9D3G:shared_process\": [], \"2BXGWF5TF:shared_process\": [], \"2BYKTADMA:shared_process\": [], \"2BYFT9HTZ:shared_process\": [], \"2BXDTJMED:shared_process\": [], \"2BZHPZ6NS:shared_process\": [], \"2BYKRWYB3:shared_process\": [], \"2BZH2UAT4:shared_process\": [], \"2BZ38J35G:shared_process\": [], \"2BXJ2X464:shared_process\": [], \"2BYQ57ED9:shared_process\": [], \"2BXDSA2SN:shared_process\": [], \"2BWZCTD2B:shared_process\": [], \"2BWT81MNU:shared_process\": [], \"2BWA7ZTRD:shared_process\": [], \"2BXW6X5KN:shared_process\": [], \"2BVWDQPXH:shared_process\": [], \"2BZGAF8KG:shared_process\": [] }, \"config\": {}, \"info\": {} } """ > $idx/note.json idx=$[$idx+1] done ``` 2. zeppelin restart or refresh notebook. 3. Try coding in any notebook. (fast) ### Screenshots (if appropriate) #### before ( 5000 notebooks)  #### after ( 5000 notebooks)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: CloverHearts <[email protected]> Closes #1533 from cloverhearts/ZEPPELIN-1559-Notebook-broadcast-opti and squashes the following commits: bd58102 [CloverHearts] id Delete unused for navbar 14e88bb [CloverHearts] selectively modified to render the Notebook list.
### What is this PR for? Enabling each user to run same interpreter. ### What type of PR is it? [Improvement] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1210 ### How should this be tested? 1. Enable shiro to use authentication mode 1. Check `per user` in your interpreter tab 1. Run different paragraphs with different users 1. Run `%spark sc.version`, you will see the two `res0: ...` in your paragraphs ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: CloverHearts <[email protected]> Author: Jongyoul Lee <[email protected]> Closes #1265 from jongyoul/ZEPPELIN-1210 and squashes the following commits: 48a0d8e [Jongyoul Lee] Fixed ZEPPELIN-1542 Fixed flaky test e84703d [Jongyoul Lee] Fixed ZEPPELIN-1542 ad80951 [Jongyoul Lee] Fixed some wrong logic of getInterpreterInstanceKey cee39f4 [Jongyoul Lee] Fixed to pass shiro information to InterpreterFactory from ZeppelinServer 5e7da34 [Jongyoul Lee] Changed instanceKey and processKey for dealing with new UI d201950 [CloverHearts] fix eqeqeq issue for frontweb b18bff4 [CloverHearts] implement frontend for interpreter per user mode and misc mode 1f64e52 [CloverHearts] change default value for pernote and peruser 787a366 [CloverHearts] change Back-end test cases and member type (perNote, perUser) 8586e1f [CloverHearts] change ui for interpreter running Per x mode 0b5d671 [Jongyoul Lee] Fixed the style 960bde1 [Jongyoul Lee] Removed SecurityUtils.getPrincipal Added fromMessage.principal to get right user 01c7cf1 [Jongyoul Lee] Fixed NPE while testing ZeppelinSparkClusterTest 1fb50ab [Jongyoul Lee] Fixed NPE while testing ZeppelinSparkClusterTest d1c4344 [Jongyoul Lee] Fixed getEditorSetting for having users' info 12a27db [Jongyoul Lee] Fixed test after rebase 510942b [Jongyoul Lee] Fixed test after rebase cb66946 [Jongyoul Lee] Fixed test after rebase 18b39bd [Jongyoul Lee] Fixed test after rebase daa634f [Jongyoul Lee] Fixed some tests after rebase ed558be [Jongyoul Lee] Fixed some tests after rebase fa7fccb [Jongyoul Lee] Fixed destroying process of remoteInterpreterProcess 0a73241 [Jongyoul Lee] Fixed conflict while rebasing. df423d3 [Jongyoul Lee] Fixed NotebookRestApiTest b151366 [Jongyoul Lee] Fixed some codes after rebase a32afd7 [Jongyoul Lee] Fixed some tests 7b7eb78 [Jongyoul Lee] Fixed some tests 47cc668 [Jongyoul Lee] Fixed tests to use AuthenticationInfo 012cf99 [Jongyoul Lee] Fixed some mismatch after rebase 9a03d40 [Jongyoul Lee] Reverted some value to default ones 8589545 [Jongyoul Lee] Added option in UI ccbedc1 [Jongyoul Lee] WIP 94dfed2 [Jongyoul Lee] WIP 6480d1d [Jongyoul Lee] resolved conflicts
…ok with group permission ### What is this PR for? Zeppelin home page list notebooks doesn't show notebook with group permission ### What type of PR is it? [Bug Fix] ### Todos * [x] - consume userAndRole instead of AuthenticationInfo ### What is the Jira issue? * [ZEPPELIN-1483](https://issues.apache.org/jira/browse/ZEPPELIN-1483) ### How should this be tested? In current scenario only those notebook lists that have direct user permission, those with group does not list up, but if user have link to those notebook, it can still be accessed. IMO the notebook with group permission should also be listed in the home screen. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <[email protected]> Author: Prabhjyot Singh <[email protected]> Closes #1454 from prabhjyotsingh/ZEPPELIN-1483 and squashes the following commits: 2484833 [Prabhjyot Singh] Merge remote-tracking branch 'origin/master' into ZEPPELIN-1483 c8d810e [Prabhjyot Singh] organise imports d3261c4 [Prabhjyot Singh] consume userAndRole instead of AuthenticationInfo
Contributor
Author
|
@jongyoul @soralee @anthonycorbacho @AhyoungRyu Thank you for review ^^ |
Contributor
|
@baekhoseok Tested and it looks good! You chose second option :) But one wired thing is I can't build with IDK what the exact cause is, I fixed this with rebasing. if you didn't set upstream yet (or you can skip this step) rebase from master |
Member
|
@AhyoungRyu the issue you raised is not caused by this pr but #1501. Can you try after clean bower cache( |
minahlee
reviewed
Oct 22, 2016
| <button class="btn btn-default btn-sm" | ||
| ng-click="showRepositoryInfo = !showRepositoryInfo"> | ||
| <i class="fa fa-database" ng-style="{color: showRepositoryInfo ? '#3071A9' : 'black' }"></i> | ||
| Repository Information |
Member
There was a problem hiding this comment.
How do you think about changing Repository Information to Repository? For me, it seems like one button taking too much of space.
Member
|
@baekhoseok Thank you for the contribution! Do you mind to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
What type of PR is it?
Improvement
Screenshots (if appropriate)
before
after
before
after
before
after
### Questions: - Does the licenses files need update? no - Is there breaking changes for older versions? no - Does this needs documentation? yes