[ZEPPELIN-1550] fixed 'add from URL' button #1523
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunho0130
changed the title
Contributor
|
+1 |
Contributor
|
@yunho0130 Thanks for your contribution. Nice catch! |
Contributor
|
Merging this if there are no more discussions :D |
Member
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Oct 17, 2016
fixed 'add from URL' button and disable backdrop function. Bug Fix None [ZEPPELIN-1550](https://issues.apache.org/jira/browse/ZEPPELIN-1550) click 'Import note' -> click 'Add from URL' -> click 'x' button -> open the dialog again -> it shows the URL page not the initial page. - before  - after  * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Yunho Maeng <[email protected]> Closes #1523 from yunho0130/ZEPPELIN-1550 and squashes the following commits: a045928 [Yunho Maeng] fixed 'add from URL' button and disable backdrop fuction when user use modal window (cherry picked from commit e5f211b) Signed-off-by: Mina Lee <[email protected]> Conflicts: zeppelin-web/src/components/noteName-import/note-import-dialog.html
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? fixed 'add from URL' button and disable backdrop function. ### What type of PR is it? Bug Fix ### Todos None ### What is the Jira issue? [ZEPPELIN-1550](https://issues.apache.org/jira/browse/ZEPPELIN-1550) ### How should this be tested? click 'Import note' -> click 'Add from URL' -> click 'x' button -> open the dialog again -> it shows the URL page not the initial page. ### Screenshots (if appropriate) - before  - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Yunho Maeng <[email protected]> Closes apache#1523 from yunho0130/ZEPPELIN-1550 and squashes the following commits: a045928 [Yunho Maeng] fixed 'add from URL' button and disable backdrop fuction when user use modal window
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? fixed 'add from URL' button and disable backdrop function. ### What type of PR is it? Bug Fix ### Todos None ### What is the Jira issue? [ZEPPELIN-1550](https://issues.apache.org/jira/browse/ZEPPELIN-1550) ### How should this be tested? click 'Import note' -> click 'Add from URL' -> click 'x' button -> open the dialog again -> it shows the URL page not the initial page. ### Screenshots (if appropriate) - before  - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Yunho Maeng <[email protected]> Closes apache#1523 from yunho0130/ZEPPELIN-1550 and squashes the following commits: a045928 [Yunho Maeng] fixed 'add from URL' button and disable backdrop fuction when user use modal window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
fixed 'add from URL' button and disable backdrop function.
What type of PR is it?
Bug Fix
Todos
None
What is the Jira issue?
ZEPPELIN-1550
How should this be tested?
click 'Import note' -> click 'Add from URL' -> click 'x' button -> open the dialog again -> it shows the URL page not the initial page.
Screenshots (if appropriate)
Questions: