[ntsekouras]

What?

Follow up of: #85081 (comment)

When the post uses the default template, the template select in the post summary shows the Select placeholder instead of the default template's name (the popover still has it checked when opened).

This is a regression from #84345, which moved the field to the @wordpress/ui SelectControl. Base UI treats an item with an empty string value as no selection, so the default template option (value: '') showed the placeholder. This PR gives the default option its own value and maps it to '' when it changes, so the saved value doesn't change. This PR updates both the block theme and the classic theme variants.

Notes

1. The same issue exists in other @wordpress/ui select consumers with an empty option (position, text shadow, legacy widget, template part tag name, PostTemplatePanel for classic themes). I'll handle these in a separate PR together with a guard in the @wordpress/ui select.

Testing Instructions

1. With a block theme, open a post that uses the default template.
2. In the post summary click the Template row and observe the select shows the default template's name (e.g. Single Posts).
3. Switch to a custom template and back to the default and save. Everything should work as before.
4. Repeat with a classic theme that has page templates.

Screenshots or screencast

Use of AI Tools

Generated with Opus 5.5 and adjusted/reviewed manually.

[github-actions]

🤖 PR meta 🤖

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

📦 Bundle size

Size Change: +35 B (0%)

Total Size: 8.96 MB

📦 View Changed

Filename	Size	Change
build/modules/core-fields/post_type_supports.min.js	81 kB	+35 B (+0.04%)

_{1927327 Run}

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric	e235573	trunk	% Change
timeToFirstByte	43.75 ms +5.26% -2.17%	41.95 ms +3.58% -2.5%	4.29%
largestContentfulPaint	78 ms +7.69% -7.69%	72 ms +2.78% -5.56%	8.33%
lcpMinusTtfb	32.4 ms +13.12% -9.88%	29.25 ms +13.16% -5.81%	10.77%
wpBeforeTemplate	22.5 ms +6.89% -2.62%	21.59 ms +4.59% -0.88%	4.21%
wpTemplate	17.79 ms +2.53% -4.72%	16.44 ms +7.6% -2.07%	8.21%
wpTotal	39.95 ms +5.81% -1.53%	38.56 ms +3.6% -2.23%	3.6%
wpMemoryUsage	7.65 MB +0% -0%	7.61 MB +0% -0%	0.46%
wpDbQueries	16 +0% -0%	16 +0% -0%	0%

front-end-classic-theme

Metric	e235573	trunk	% Change
timeToFirstByte	36.15 ms +4.56% -3.32%	34.5 ms +4.2% -1.74%	4.78%
largestContentfulPaint	84 ms +0% -0%	80 ms +0% -5%	5%
lcpMinusTtfb	47.1 ms +4.25% -3.82%	42.85 ms +5.02% -1.75%	9.92%
wpBeforeTemplate	19.63 ms +2.9% -3.31%	18.87 ms +1.54% -2.81%	4.03%
wpTemplate	13.44 ms +4.32% -3.05%	12.67 ms +2.29% -2.05%	6.08%
wpTotal	33.24 ms +3.97% -3.82%	31.66 ms +4.52% -1.93%	4.99%
wpMemoryUsage	6.34 MB +0% -0%	6.30 MB +0% -0%	0.57%
wpDbQueries	13 +0% -0%	13 +0% -0%	0%

media-processing

Metric	e235573	trunk	% Change
mediaProcessingJpeg	354.54 ms +0.81% -1.78%	346.79 ms +1.74% -1.83%	2.23%
mediaProcessingAvif	5092.01 ms +1.11% -0.51%	5011.1 ms +0.32% -0.38%	1.61%
mediaProcessingJpegToAvif	3469.28 ms +0.2% -0.99%	3404.5 ms +0.29% -0.9%	1.9%

media-upload

Metric	e235573	trunk	% Change
jpegUploadProcessing	1411.5 ms +1.67% -1.57%	1401.61 ms +0.49% -0.56%	0.71%
pngUploadProcessing	181.79 ms +6.02% -2.2%	197.15 ms +6.45% -7.53%	-7.79%
largeJpegUploadProcessing	1393.16 ms +0.69% -0.17%	1405.25 ms +0.23% -0.38%	-0.86%
multipleImageUploadProcessing	1488.94 ms +0.21% -0.71%	1488.45 ms +1.32% -1.07%	0.03%

post-editor

Metric	e235573	trunk	% Change
serverResponse	255.07 ms +11.2% -5.57%	285.86 ms +9.12% -4.8%	-10.77%
firstPaint	220.77 ms +52.67% -23.59%	245.95 ms +51.92% -16.47%	-10.24%
domContentLoaded	749.39 ms +4.94% -3.94%	842.03 ms +1.64% -4.76%	-11%
loaded	750.27 ms +5% -3.95%	843.07 ms +1.62% -4.76%	-11.01%
firstContentfulPaint	337.96 ms +4.12% -31.74%	378.67 ms +2.77% -22.25%	-10.75%
firstBlock	2282.42 ms +6.68% -2.57%	2540.36 ms +2.93% -3.71%	-10.15%
type	14.67 ms +6.13% -4.57%	14.28 ms +7.77% -2.1%	2.73%
typeWithoutInspector	14.04 ms +2.42% -5.27%	14.77 ms +5.96% -6.43%	-4.94%
typeWithTopToolbar	17.15 ms +3.21% -4.78%	18.26 ms +7.23% -6.57%	-6.08%
typeContainer	6.67 ms +4.5% -4.05%	7.43 ms +9.56% -14.27%	-10.23%
focus	84.28 ms +5.46% -4.58%	76.57 ms +4.99% -4.91%	10.07%
firstFocus	185.2 ms +0% -0%	158.52 ms +0% -0%	16.83%
selectAll	346.85 ms +6.58% -1.55%	367.3 ms +4.28% -7.95%	-5.57%
listViewOpen	47.44 ms +12.2% -5.67%	46.33 ms +6.19% -8.14%	2.4%
inserterOpen	26.58 ms +1.96% -2.14%	26.27 ms +17.36% -4.11%	1.18%
inserterHover	9.02 ms +9.65% -7.32%	8.99 ms +6.67% -6.34%	0.33%
inserterSearch	6.66 ms +2.25% -2.1%	6.83 ms +4.39% -4.1%	-2.49%
loadPatterns	456.76 ms +4.92% -3%	433.81 ms +4.58% -2.29%	5.29%
wpTotal	248.22 ms +11.54% -5.67%	278.82 ms +8.92% -5.05%	-10.97%
wpMemoryUsage	14.66 MB +0% -0%	14.63 MB +0% -0%	0.26%
wpDbQueries	55 +0% -0%	55 +0% -0%	0%

site-editor

Metric	e235573	trunk	% Change
serverResponse	524.79 ms +3.44% -3.95%	505.31 ms +4.57% -7.04%	3.86%
firstPaint	251.63 ms +25.82% -4.44%	255.04 ms +18.04% -1.31%	-1.34%
domContentLoaded	1296.45 ms +0.49% -1.16%	1313.65 ms +1.68% -1.9%	-1.31%
loaded	1297.74 ms +0.52% -1.16%	1314.84 ms +1.66% -1.92%	-1.3%
firstContentfulPaint	521.07 ms +3.06% -3.21%	533.82 ms +2% -3.39%	-2.39%
firstBlock	4976.5 ms +1.61% -0.72%	5042.16 ms +0.95% -1.22%	-1.3%
type	19.61 ms +6.32% -6.53%	19.73 ms +5.63% -2.94%	-0.61%
navigate	122.94 ms +17.81% -3.25%	122.4 ms +7.03% -3.01%	0.44%
loadPatterns	1280.89 ms +8.56% -1.71%	1345.06 ms +1.97% -3.06%	-4.77%
loadPages	1093.68 ms +2.44% -0.99%	1083.63 ms +2.48% -4.77%	0.93%
wpTotal	514.92 ms +3.26% -4.12%	495.09 ms +4.63% -7.06%	4.01%
wpMemoryUsage	12.70 MB +0% -0%	12.66 MB +0% -0%	0.29%
wpDbQueries	44 +2.27% -0%	44 +2.27% -0%	0%

_{1927327 Run}

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

Regression: updating a specific option will only change its value and will not corrupt others in /test/e2e/specs/editor/various/core-settings.spec.js, passed after 1 failed attempt.

Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
    "rewrite_rules",
-   "SERIALIZED DATA",
+   "",
  ]
    at forEach (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/core-settings.spec.js:46:26)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/core-settings.spec.js:43:35

default to a list of pages if there are no menus in /test/e2e/specs/editor/blocks/navigation.spec.js, passed after 1 failed attempt.

Error: expect(locator).toBeVisible() failed

Locator: locator('[name="editor-canvas"]').contentFrame().getByRole('document', { name: 'Block: Page List' })
Expected: visible
Timeout: 10000ms
Error: element(s) not found

Call log:
  - Expect "toBeVisible" locator('[name="editor-canvas"]').contentFrame().getByRole('document', { name: 'Block: Page List' }) with timeout 10000ms
  - waiting for locator('[name="editor-canvas"]').contentFrame().getByRole('document', { name: 'Block: Page List' })

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:34:34

drags a multi-selection from anywhere inside it in /test/e2e/specs/editor/various/draggable-blocks.spec.js, passed after 1 failed attempt.

TypeError: Cannot read properties of null (reading 'y')
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/draggable-blocks.spec.js:824:57
    at dragSelectionBelowLanding (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/draggable-blocks.spec.js:823:3)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/draggable-blocks.spec.js:844:3

three users concurrently edit a large post with diverse blocks in /test/e2e/specs/editor/collaboration/collaboration-stress.spec.ts, passed after 1 failed attempt.

TimeoutError: locator.waitFor: Timeout 17500ms exceeded.
Call log:
  - waiting for getByRole('button', { name: /Collaborators list/ }) to be visible

    at map (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/collaboration/fixtures/collaboration-utils.ts:193:7)
    at CollaborationUtils.waitForMutualDiscovery (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/collaboration/fixtures/collaboration-utils.ts:188:10)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/collaboration/collaboration-stress.spec.ts:416:28

_{1927327 Run}

[oandregal]

Thanks for the quick follow-up.

cc @ciampo @mirka for awareness. This sounds like something that would impact many other places.

[ciampo]

Nice fix 🚀

[ciampo]

cc @ciampo @mirka for awareness. This sounds like something that would impact many other places.

I'm not sure we could/should change the implementation on the @wordpress/ui side, but here are a few ideas:

• Add a development warning for value: '' when using the default serialization. Honor custom itemToStringValue implementations;
• Improve the documentation around the difference between a null item (which lets users clear the selection) and a named default option (which needs a nonempty value);
• Update the test fixture, which currently uses { value: '', label: 'Select' } and hides this problem.
• Create a specific migration for SelectControl, like we've done for other components

Let's wait for @mirka 's feedback too, as the resident expert

Edit: I see that some of these suggestions are actually already implemented in #85172 :)

[jameskoster]

This is great! One small detail; do you think the default template should be marked as such? IE Single Entries (default), otherwise it's unclear if you want to reset to the default template via he control.