Repository navigation
Fields: Fix the page title row jumping on hover when a page type badge is shown - #84368
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the 📦 Bundle sizeSize Change: +94 B (0%) Total Size: 8.38 MB 📦 View Changed
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
🏁 Flaky testsSome tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information. refuses the drop and uploads nothing in
|
|
Thanks for the quick fix! |
What?
Fixes: #84335
In #82499 the page type badge of the page title field was migrated to the
Badgefrom@wordpress/ui. The oldBadgedidn't wrap its content and truncated it with an ellipsis, but the new one wraps. So in the list layout, when the primary action shows up on hover, the badge breaks into two lines and the row jumps.This PR adds the same styles to the badge in the field, so it behaves like before (on hover both the title and the badge get truncated). I didn't touch the
Badgecomponent itself, since the direction is for consumers to handle truncation (#78589 (comment)).Screenshots or screencast
Notes
This should be ported in #83368 when lands.
Testing Instructions
listlayout and hover the row of that page.Use of AI Tools
Fable 5.1 with direction, changes and review