Repository navigation
Stylelint: Consolidate Lint rules for simplification - #71235
Open
im3dabasia wants to merge 3 commits into
Open
im3dabasia wants to merge 3 commits into
im3dabasia wants to merge 3 commits into
Conversation
im3dabasia
marked this pull request as ready for review
August 25, 2025 03:59
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jsnajdr
reviewed
Oct 17, 2025
| return `Avoid using "${ value }" in "${ property }". --wp-components-color-* variables are not ready to be used outside of the components package.`; | ||
| } | ||
| return `Avoid "${ value }" for "${ property }".`; | ||
| }, |
Member
There was a problem hiding this comment.
In the message function we don't need to perform the entire value test again, we only need to switch on the property name:
switch ( property ) {
case 'flex-direction':
return "Avoid -reverse";
default:
return "Avoid --wp-components-color-*";
}
im3dabasia
force-pushed
the
try/69590-follow-up
branch
from
February 9, 2026 11:39
22b8893 to
3359d05
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #69590 (comment)
Why?
Consolidate the rules.
How?
Use only
declaration-property-value-disallowed-list