[ellatrix]

What?

Dragging selected text moves the text, within a field or into another text field. Part of #67305. Fixes #3339.

Why?

Dragging selected text did nothing: every drag inside a block was prevented.

How?

1. Drag
   • A drag of a text selection within one rich text field is no longer prevented.
   • The drag data is the selected rich text, as plain text and HTML.
   • The browser keeps the drag and its drop caret.
2. Drop
   • The field the text is dropped on inserts it the way it inserts pasted content, through its own change handler, then selects it. Paste filtering, bindings and disabled fields apply.
   • Text dragged from a field is removed there through that field's change handler. The move is one undo level.
   • Text dropped from outside the editor goes through the same path.
   • The block drop zones stay out of text drags.

A selection across blocks still can't be dragged. Browsers without caretPositionFromPoint (Safari before 26.2) keep text drags prevented.

Testing Instructions

1. Select a word in a paragraph and drag it elsewhere in the paragraph: the drop caret follows the pointer and the word moves.
2. Drag a selected word into another paragraph: it moves there with its formatting. Undo restores both paragraphs.
3. Drag formatted text from another app into a paragraph: it lands at the drop caret with its inline styles removed.

Use of AI Tools

Written with the help of Claude Code.

[github-actions]

Size Change: +440 B (+0.01%)

Total Size: 7.72 MB

📦 View Changed

Filename	Size	Change
build/scripts/block-editor/index.min.js	461 kB	+343 B (+0.07%)
build/styles/block-editor/content-rtl.css	5.69 kB	+27 B (+0.48%)
build/styles/block-editor/content-rtl.min.css	4.16 kB	+22 B (+0.53%)
build/styles/block-editor/content.css	5.69 kB	+27 B (+0.48%)
build/styles/block-editor/content.min.css	4.16 kB	+21 B (+0.51%)

_{compressed-size-action}

[github-actions]

Flaky tests detected in 47aa503.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/31772524212
📝 Reported tests:

adds and activates a new tab when pressing Enter at the end of a tab label in /test/e2e/specs/editor/blocks/tabs.spec.js, passed after 1 failed attempt.

Error: expect(locator).toHaveCount(expected) failed

Locator:  locator('[name="editor-canvas"]').contentFrame().getByRole('tab')
Expected: 3
Received: 2
Timeout:  5000ms

Call log:
  - Expect "toHaveCount" with timeout 5000ms
  - waiting for locator('[name="editor-canvas"]').contentFrame().getByRole('tab')
    14 × locator resolved to 2 elements
       - unexpected value "2"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/tabs.spec.js:146:25

[github-actions]

🤖 PR meta 🤖

🎉 Props

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @mapk, @GlennMartin1.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: mapk, GlennMartin1.

Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: mtias <matveb@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

📦 Bundle size

Size Change: +1.12 kB (+0.01%)

Total Size: 8.96 MB

📦 View Changed

Filename	Size	Change
build/scripts/block-editor/index.min.js	601 kB	+1.12 kB (+0.19%)

_{3e921cd Run}

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric	69c8bea	trunk	% Change
timeToFirstByte	48 ms +2.4% -3.96%	47.9 ms +5.22% -3.76%	0.21%
largestContentfulPaint	80 ms +12.5% -0%	82 ms +9.76% -2.44%	-2.44%
lcpMinusTtfb	34.25 ms +15.04% -6.57%	32.55 ms +12.29% -3.53%	5.22%
wpBeforeTemplate	24.27 ms +5.93% -2.43%	23.87 ms +5.4% -1.72%	1.68%
wpTemplate	19.39 ms +4.07% -3.92%	19.99 ms +1.15% -5.9%	-3%
wpTotal	44.2 ms +2.31% -4.12%	43.96 ms +5.78% -3.5%	0.55%
wpMemoryUsage	7.64 MB +0% -0%	7.60 MB +0% -0%	0.58%
wpDbQueries	16 +0% -0%	16 +0% -0%	0%

front-end-classic-theme

Metric	69c8bea	trunk	% Change
timeToFirstByte	40.7 ms +4.42% -2.21%	40.35 ms +2.97% -4.34%	0.87%
largestContentfulPaint	92 ms +4.35% -0%	92 ms +0% -4.35%	0%
lcpMinusTtfb	52.2 ms +2.11% -1.72%	50.65 ms +1.97% -1.38%	3.06%
wpBeforeTemplate	21.52 ms +7.85% -0.79%	21.22 ms +2.45% -2.5%	1.41%
wpTemplate	15.62 ms +2.43% -2.82%	15.34 ms +3.39% -7.11%	1.83%
wpTotal	37.57 ms +4.21% -2.5%	36.91 ms +2.93% -4.33%	1.79%
wpMemoryUsage	6.33 MB +0% -0%	6.29 MB +0% -0%	0.72%
wpDbQueries	13 +0% -0%	13 +0% -0%	0%

media-processing

Metric	69c8bea	trunk	% Change
mediaProcessingJpeg	391.74 ms +1.78% -0.3%	390.98 ms +1.11% -0.09%	0.19%
mediaProcessingAvif	5720.98 ms +0.56% -0.06%	5698.22 ms +0.18% -0.16%	0.4%
mediaProcessingJpegToAvif	3923.46 ms +0.36% -0.51%	3902.3 ms +0.13% -0.13%	0.54%

media-upload

Metric	69c8bea	trunk	% Change
jpegUploadProcessing	1444.58 ms +36.26% -1.26%	1423.41 ms +0.56% -0.6%	1.49%
pngUploadProcessing	222.45 ms +3.4% -7.04%	216.2 ms +4.51% -3.06%	2.89%
largeJpegUploadProcessing	1418.35 ms +1.09% -0.86%	1412.37 ms +0.74% -0.75%	0.42%
multipleImageUploadProcessing	1589.41 ms +6.86% -1.02%	1558.28 ms +1.96% -0.55%	2%

post-editor

Metric	69c8bea	trunk	% Change
serverResponse	355.83 ms +3.67% -1.93%	321.95 ms +13.32% -1.15%	10.52%
firstPaint	285.43 ms +35.81% -29.86%	225.06 ms +62% -27.05%	26.82%
domContentLoaded	904.46 ms +2.97% -5.31%	908.99 ms +2.37% -4.34%	-0.5%
loaded	905.37 ms +2.96% -5.31%	909.91 ms +2.36% -4.34%	-0.5%
firstContentfulPaint	392.32 ms +5.07% -7.97%	403.03 ms +2.48% -9.54%	-2.66%
firstBlock	2706.78 ms +4.55% -0.84%	2626.05 ms +0.64% -0.73%	3.07%
type	15.76 ms +3.17% -3.55%	15.9 ms +6.67% -3.9%	-0.88%
typeWithoutInspector	15.85 ms +2.27% -5.93%	15.6 ms +2.56% -2.37%	1.6%
typeWithTopToolbar	20.94 ms +0.86% -4.97%	20.27 ms +3.16% -3.8%	3.31%
typeContainer	7.66 ms +11.62% -3.52%	7.89 ms +5.32% -7.86%	-2.92%
focus	104.2 ms +4.59% -7.09%	97.96 ms +4.64% -4.23%	6.37%
firstFocus	189.14 ms +0% -0%	191.92 ms +0% -0%	-1.45%
selectAll	387.8 ms +2.1% -1.25%	398.31 ms +4.01% -0.06%	-2.64%
listViewOpen	60.72 ms +1.27% -1.76%	59.66 ms +4.54% -9.97%	1.78%
inserterOpen	32.92 ms +10.42% -3.37%	33.97 ms +9.57% -12.81%	-3.09%
inserterHover	10.34 ms +9.86% -8.9%	10.86 ms +9.85% -12.06%	-4.79%
inserterSearch	7.67 ms +9.52% -3.65%	7.58 ms +2.24% -6.99%	1.19%
loadPatterns	536.28 ms +1.7% -2.51%	510.74 ms +3.15% -0.64%	5%
wpTotal	346.51 ms +3.92% -2.16%	313.15 ms +13.36% -1.19%	10.65%
wpMemoryUsage	14.65 MB +0% -0%	13.58 MB +0% -0%	7.87%
wpDbQueries	55 +0% -0%	55 +0% -0%	0%

site-editor

Metric	69c8bea	trunk	% Change
serverResponse	248.8 ms +1.93% -10.2%	239.81 ms +4.85% -7.79%	3.75%
firstPaint	259.87 ms +32.35% -43.26%	220.51 ms +39.72% -29.64%	17.85%
domContentLoaded	765.29 ms +1.91% -1.32%	762.69 ms +1.89% -2.89%	0.34%
loaded	766.75 ms +1.81% -1.41%	763.48 ms +1.89% -2.88%	0.43%
firstContentfulPaint	319.97 ms +12.77% -9.14%	329.58 ms +8.48% -6.31%	-2.92%
firstBlock	2858.36 ms +2.9% -3.22%	2793.07 ms +2.73% -1.35%	2.34%
type	14.05 ms +0.5% -3.99%	14.56 ms +1.79% -6.59%	-3.5%
navigate	68.01 ms +31.95% -0.91%	100.01 ms +0.42% -10.42%	-32%
loadPatterns	942.62 ms +20.94% -11.06%	1006.13 ms +9.65% -16.5%	-6.31%
loadPages	956.17 ms +1.55% -1.8%	957.24 ms +9.43% -2.34%	-0.11%
wpTotal	242.79 ms +1.78% -10.53%	233.67 ms +4.86% -8.01%	3.9%
wpMemoryUsage	12.66 MB +0% -0%	12.64 MB +0% -0%	0.2%
wpDbQueries	44.5 +1.12% -1.12%	44.5 +1.12% -1.12%	0%

_{3e921cd Run}

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

Regression: updating a specific option will only change its value and will not corrupt others in /test/e2e/specs/editor/various/core-settings.spec.js, passed after 1 failed attempt.

Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
    "rewrite_rules",
-   "SERIALIZED DATA",
+   "",
  ]
    at forEach (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/core-settings.spec.js:46:26)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/core-settings.spec.js:43:35

default to a list of pages if there are no menus in /test/e2e/specs/editor/blocks/navigation.spec.js, passed after 1 failed attempt.

Error: expect(locator).toBeVisible() failed

Locator: locator('[name="editor-canvas"]').contentFrame().getByRole('document', { name: 'Block: Page List' })
Expected: visible
Timeout: 10000ms
Error: element(s) not found

Call log:
  - Expect "toBeVisible" locator('[name="editor-canvas"]').contentFrame().getByRole('document', { name: 'Block: Page List' }) with timeout 10000ms
  - waiting for locator('[name="editor-canvas"]').contentFrame().getByRole('document', { name: 'Block: Page List' })

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:34:34

drags a multi-selection from a block nested in a selected block in /test/e2e/specs/editor/various/draggable-blocks.spec.js, passed after 1 failed attempt.

TypeError: Cannot read properties of null (reading 'y')
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/draggable-blocks.spec.js:989:57
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/draggable-blocks.spec.js:988:3

_{3e921cd Run}

[ellatrix]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: WordPress/gutenberg/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 02588283-6964-437a-b46d-dea5794c8f18

📥 Commits

Reviewing files that changed from the base of the PR and between 67be962 and 3e921cd.

📒 Files selected for processing: 8

• packages/block-editor/src/components/block-list/use-block-props/use-selected-block-event-handlers.js
• packages/block-editor/src/components/rich-text/event-listeners/drag-and-drop.ts
• packages/block-editor/src/components/rich-text/event-listeners/index.js
• packages/block-editor/src/components/rich-text/event-listeners/paste-handler.js
• packages/block-editor/src/components/writing-flow/types.ts
• packages/block-editor/src/components/writing-flow/use-clipboard-handler.ts
• test/e2e/specs/editor/blocks/paragraph.spec.js
• test/e2e/specs/editor/various/draggable-blocks.spec.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Summary

Summary by CodeRabbit

• New Features
  • Added support for dragging selected text between rich-text fields and within the same field.
  • The selection moves to the drop location, with support for plain-text and HTML content dragged from outside the editor.
  • Drops onto the dragged text are canceled, and drag-and-drop actions support undo.
• Tests
  • Added browser coverage for moving selected text between paragraphs and within a paragraph, external text drops, multiline insertion, and undo behavior.

The block editor now supports dragging selected text within and between rich-text fields. Drop events use the paste insertion flow. Firefox and WebKit tests cover text moves, external drops, self-drops, and undo behavior.

Changes: Selected-text dragging

Layer / File(s)	Summary
Handle selected-text drag and drop packages/block-editor/src/components/rich-text/event-listeners/drag-and-drop.ts, packages/block-editor/src/components/block-list/use-block-props/use-selected-block-event-handlers.js	Supported text selections are serialized for dragging. Drop positions are resolved, source text is removed when needed, undo state is recorded, and inserted text is selected.
Integrate drops with paste handling packages/block-editor/src/components/rich-text/event-listeners/*, packages/block-editor/src/components/writing-flow/*	Drop listeners are registered for editable fields. Plain text and HTML drops use paste processing, while unsupported transfers remain ignored.
Validate text and block drag behavior test/e2e/specs/editor/various/draggable-blocks.spec.js, test/e2e/specs/editor/blocks/paragraph.spec.js	End-to-end tests cover text movement, self-drops, external content, multiline drops, undo behavior, and block drag payloads.

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Feature · Severity of issue fixed: Medium

Suggested reviewers: ciampo

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant RichTextDragHandlers
  participant WritingFlow
  participant RichTextFields
  User->>RichTextDragHandlers: Drag selected text
  RichTextDragHandlers->>RichTextFields: Resolve the drop position
  RichTextDragHandlers->>WritingFlow: Pass drop data to paste handling
  WritingFlow->>RichTextFields: Insert text and update selection
  RichTextFields-->>User: Show moved or inserted text

Loading

Merge Risk: ⚪ Minimal · up to 3e921

No identified issue prevents merging after normal checks.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 8 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description check		The description clearly explains the implementation and testing for moving dragged text selections within and between rich-text fields.
Title check		The title concisely and accurately identifies the main change: moving a dragged text selection.
Linked Issues check		Issue #3339 requests dragging highlighted text to a new insertion point. The PR adds rich-text drag handling that transfers plain text and HTML, preserves the browser drop caret, inserts through field…
Out of Scope Changes check		The changes stay within selected-text drag and drop behavior for the block editor. The drag utility, paste-handler changes, writing-flow type changes, block-event handling, and drag tests support text…

Full details: Linked Issues check

Explanation

Issue #3339 requests dragging highlighted text to a new insertion point. The PR adds rich-text drag handling that transfers plain text and HTML, preserves the browser drop caret, inserts through field paste and change handling, removes source text, and preserves selection and undo behavior. The end-to-end test summary covers same-field moves, cross-field moves, external drops, formatting removal, and undo. The stated scope does not include cross-block selections or image-anchor movement.

Full details: Out of Scope Changes check

Explanation

The changes stay within selected-text drag and drop behavior for the block editor. The drag utility, paste-handler changes, writing-flow type changes, block-event handling, and drag tests support text insertion, source removal, drop-zone behavior, or regression coverage. No unrelated change is shown in the available PR evidence.

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ellatrix]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.