Skip to content

Added a help box to inform users of the potential dependency to directional lights when baking. #6059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 8, 2021
Merged

Added a help box to inform users of the potential dependency to directional lights when baking. #6059

merged 5 commits into from
Nov 8, 2021

Conversation

@JulienIgnace-Unity
Copy link
Contributor

@JulienIgnace-Unity JulienIgnace-Unity commented Oct 19, 2021

Purpose of this PR

Added a help box to inform users of the potential dependency to directional lights when baking.

Testing status

Checked that the info box appeared correctly

image

@github-actions
Copy link

github-actions bot commented Oct 19, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Oct 19, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

JMargevics
JMargevics approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@JMargevics JMargevics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense. I'd rephrase to remove double "depend", otherwise no issues ✔👍

@ValGrimm-U3D ValGrimm-U3D requested review from ValGrimm-U3D and removed request for Vic-Cooper October 27, 2021 17:07
@ValGrimm-U3D
Copy link
Contributor

ValGrimm-U3D commented Oct 27, 2021

I've been assigned this review as it relates to the documentation work I am doing, so I've replaced Vic with myself as the docs reviewer.

@sebastienlagarde
Copy link
Contributor

sebastienlagarde commented Nov 4, 2021

Thanks @ValGrimm-U3D , any update?

@ValGrimm-U3D
Copy link
Contributor

ValGrimm-U3D commented Nov 5, 2021

Thanks @ValGrimm-U3D , any update?

I am waiting for a response from @JulienIgnace-Unity on my comment on line 213 of com.unity.render-pipelines.high-definition/Editor/Sky/HDLightingWindowEnvironmentSection.cs

ValGrimm-U3D
ValGrimm-U3D suggested changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@ValGrimm-U3D ValGrimm-U3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a comment on line 213 of com.unity.render-pipelines.high-definition/Editor/Sky/HDLightingWindowEnvironmentSection.cs

@ValGrimm-U3D
Copy link
Contributor

ValGrimm-U3D commented Nov 5, 2021

Thanks @ValGrimm-U3D , any update?

I am waiting for a response from @JulienIgnace-Unity on my comment on line 213 of com.unity.render-pipelines.high-definition/Editor/Sky/HDLightingWindowEnvironmentSection.cs

I just now noticed that my comment has been in pending for many days because I forgot to submit my review, clearly I've gotten too used to Ono . . . I'll remember this in the future. My sincere apologies.

@sebastienlagarde sebastienlagarde changed the base branch from master to hd/bugfix November 5, 2021 09:52
ValGrimm-U3D
ValGrimm-U3D approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@ValGrimm-U3D ValGrimm-U3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sebastienlagarde sebastienlagarde changed the base branch from hd/bugfix to master November 8, 2021 16:59
@JulienIgnace-Unity JulienIgnace-Unity merged commit 70acbe0 into master Nov 8, 2021
@JulienIgnace-Unity JulienIgnace-Unity deleted the hd/static-lighting-helpbox branch November 8, 2021 17:00
sebastienlagarde pushed a commit that referenced this pull request Nov 10, 2021
@JulienIgnace-Unity @sebastienlagarde
Added a help box to inform users of the potential dependency to dire…
d1580d0 
…ctional lights when baking. #6059
sebastienlagarde added a commit that referenced this pull request Nov 10, 2021
@sebastienlagarde @anisunity
@pmavridis @kecho @adrien-de-tocqueville @JulienIgnace-Unity @Vic-Cooper @remi-chapelain @FrancescoC-unity @johnpars @CifaCia @slunity @eturquin @Adrian1066 @alex-vazquez @RSlysz @JarkkoUnity @robinb-u3d
[HDRP][Backport 21.2] Backport various PRs (#6265)
5b93a8a 
* Fixed Shadow Matte not appearing in ray tracing effects (case 1364005). #6209

* [HDRP] Physically based depth of field optimizations #5996

* Fixing crash when creating area light. #6220

* Update 5014_VolumetricCloudsBanding.png

* Fix order of render targets in shaderpass forward #6091

* Merge Hd/bugfix #6213

* Added a help box to inform users of the potential dependency to directional lights when baking. #6059

* Exposed the volumetric clouds transmittance for volumetric clouds (case 1373283). #6228

* Reviewed doc updated from #5771 (#6255)

Updated docs that mentioned the new FPTL limit.

* Add coverage for path/ray-tracing double sided override #6250

* Fix some burst warnings for player creation on latest trunk (#6263)

* Focus distance in path traced depth of field now takes into account the focus mode setting (#6253)

* [HDRP] Fix AxF debug output in certain configurations (#4641)

* Fix AxF debug output in certain configurations.

* Update comment

* Fix SSR accumulation white flash (#4648)

* Fix white flash

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Display Info Box when MSAA + ray tracing is onr (#4627)

* Show info box when ray tracing is enabled.

* Changelog

* Move below MSAA

Co-authored-by: sebastienlagarde <[email protected]>

* Fix distortion when resizing the window in player builds with the Graphics Compositor enabled (#4593)

Co-authored-by: sebastienlagarde <[email protected]>

* Add support for the camera bridge in the graphics compositor (#4599)

* Fix Jittered Project Matrix Infinite Far Clip Plane  (#4638)

* Reconstruct jittered projection matrix far plane (for Infinite )

* Changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed a memory leak related to not disposing of the RTAS at the end HDRP's lifecycle. (#4688)

Co-authored-by: sebastienlagarde <[email protected]>

* Fix custom pass utils Blur + Copy overdraw. (#4623)

* Fix overdraw in custom pass utils blur function

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix draw procedural invalid pass idx 1 on first template load (#4632)

* Fix

* changelog

* Force sync compilation for TAA

Co-authored-by: CifaCia <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>

* Changed light reset to preserve type (#4624)

Co-authored-by: sebastienlagarde <[email protected]>

* Revert "Add support for the camera bridge in the graphics compositor (#4599)"

This reverts commit 2325e3f.

* AxF carpaint: Fix a compilation issue on Vulkan until the cpp HLSLcc side is updated. (case 1335737, related to 1314040) (#4691)

Co-authored-by: sebastienlagarde <[email protected]>

* Revert "Revert "Add support for the camera bridge in the graphics compositor (#4599)""

This reverts commit 30fffd5.

* revert: Fix distortion when resizing the window in player builds with the Graphi

* Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). (#4626)

* Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904).

* Add test scene

Co-authored-by: Remi Chapelain <[email protected]>
Co-authored-by: Sebastien Lagarde <[email protected]>

* Fix for discrepancies in saturation and intensity between screen space refraction and probe refraction (#4653)

* Delete the second transmittance mul

* Changelog

Co-authored-by: Sebastien Lagarde <[email protected]>

* Fix a Divide-by-Zero Warning for some Anisotropic Models (Fabric, Lit) (#4636)

* Initialize the shading normal to a non-zero value for anisotropy

* Changelog

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix VfX lit particle AOV output color space (#4646)

* Fix VfX lit particle aov output color space

* Update comment

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP][Path Tracing] Fixed transparent unlit (#4605)

* Fixed issue with transparent unlit.

* Updated changelog.

* Reverted accidental change to default mtl.

Co-authored-by: sebastienlagarde <[email protected]>

* Fix distortion with MSAA (#4711)

* Fix contact shadow debug views (#4720)

* Fix

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Update Decal-Projector.md (#4695)

* [HDRP] Fixed nullref when deleting the texture asset assigned in a local volumetric fog volume (#4728)

* Fixed nullref when deleting the 3D mask of a density volume (case 1339330)

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix decal layer enum (#4753)

* Fix typo

* Fixed reflection probes being injected into the ray tracing light cluster even if not baked (case 1329083). (#4640)

Co-authored-by: sebastienlagarde <[email protected]>

* Ignore hybrid duplicated reflection probes during light baking (#4663)

* Ignore hybrid duplicated reflection probes during light baking

* test path instead of scene

Co-authored-by: sebastienlagarde <[email protected]>

* Fix double sided option moving when toggling it in the material UI (#4725)

* Fix double sided option moving when toggling it in the material UI (case 1328877)

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix formatting

* Fix volumetric fog in planar reflections (#4736)

* Fix planar reflection

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix motion blur compute dispatch size (#4737)

Co-authored-by: sebastienlagarde <[email protected]>

* - Updated the recursive rendering documentation (case 1338639). (#4759)

* - Updated the recursive rendering documentation (case 1338639).

* review fixes

Co-authored-by: sebastienlagarde <[email protected]>

* Fix issue with OnDemand directional shadow map being corrupted when reflection probe are updated same frame (#4812)

* Don't mark as rendered for reflection probes as we want the cached version to be from main view

* Do the thing just for directional

* Doc update

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix cropping issue with the compositor camera bridge (#4802)

Co-authored-by: sebastienlagarde <[email protected]>

* Fix for unused resources in depth of field (#4796)

* Removing the word Radii from exposure settings (#4854)

* Rename in UX

* Update docs

* [HDRP][Path Tracing] Support for shadow mattes (#4745)

* Shadow matte support.

* Updated changelog.

* Only take occluders into account, closer match to raster mode.

* Added test scene.

Co-authored-by: sebastienlagarde <[email protected]>

* Revert "[HDRP][Path Tracing] Support for shadow mattes (#4745)"

This reverts commit 85ebbc2.

* Fixed the transparent cutoff not working properly in semi-transparent  and color shadows (case 1340234). (#4756)

* Fixed the transparent cutoff not working properly in semi-transparent and color shadows (case 1340234).

* Update test ref image

Co-authored-by: Remi Chapelain <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>

* Use non jittered projection in outline pass (#4836)

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP][Path Tracing] Sky settings now properly taken into account when using recorder (#4856)

* Make sure sky settings are correctly set when recording.

* Updated changelog.

Co-authored-by: sebastienlagarde <[email protected]>

* Fix Resolution Issues for Physically Based Depth of Field (#4848)

* Add the necesarry texture coordinate clamping for RTHandle for color pyramid sampling

* Add some resolution independence, fitted for 1920x1080

* Changelog

* Switch back to point sampling from trilinear, with commentary

* Update test reference images

* Small correction to the point sampling, always sample mip 0.

* Re-update the test images, for mip 0 color sampling

* Use a simpler UV scaling/clamping since we are now point sampling.

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed bug introduced by sky-for-recorder support. (#4906)

* [Fogbugz 1341576] Memory leaks when the player is paused, and the user changes pipeline… (#4845)

* Memory leaks when the player is paused, and the user changes pipeline settings

* changelog

* [HDRP] Fixed shadergraph double save (#4916)

* Don't need to save twice shadergraph the first time we create a graph

* Updated changelog

* Write 0 instead of micro sized motion vectors + fix extremely fast velocities (#4820)

* Kill micromovements.

* Do same for camera

* Debug view update

* Changelog

* Remove unnecessary comment

* Fix excessive velocity end up marked as no velocity

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix material upgrader (#4821)

* Fix HDRP material upgrade failing when there is a texture inside the builtin resources assigned in the material

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix custom pass volume not executed in scene view (#4860)

* Fix custom pass volume not executed in scene view because of the volume culling mask

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix reflection probe tootltip (#4890)

Co-authored-by: sebastienlagarde <[email protected]>

* Updated the Physically Based Sky documentation for baked lights (#4891)

* Updated the Physically Based Sky documentation for baked lights

* Rewrite

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed remapping of depth pyramid debug (#4893)

* Fixed remapping of depth pyramid debug

* Removed debug pragma

* Update changelog

* Updated tooltip

* Fix wobble-like (or tearing-like) SSAO issues when temporal reprojection is enabled. (#4895)

* Fix AO perceived wobble

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix Asymmetric Projection Matrices and Fog / Pathtracing (#4926)

* Check for asymmetric projections and choose the generic path if so.

* Fix asymmetric projections for the pathtracer ray generation.

* Changelog

* Simplify the matrix multiplication for computing the generic matrix.

Co-authored-by: sebastienlagarde <[email protected]>

* Revert: Fix wobble-like (or tearing-like) SSAO issues when temporal reprojection…

* Fix GBuffer depth debug mode (#5054)

* Fixed Volume Gizmo size when rescaling parent GameObject (#4915)

* Fix Vertex Color Mode documentation (#4976)

* Fix wobble-like (or tearing-like) SSAO issues when temporal reprojection is enabled.  (#4986)

* Fix AO perceived wobble

* changelog

* Update screenshots

Co-authored-by: sebastienlagarde <[email protected]>

* Fix formatting in NestedOverrideCameraRendering

* [HDRP] Fix white flash with SSR when resetting camera history (#5089)

* Fix white flash with SSR when resetting camera history

* Move branch login inside GetPreviousExposureTexture

* Fix for fixed exposure

* [Fobguz # 1348357] VFX Particle templates missing stencil flags (#5080)

* Adding missing macro for stencil flags in particle forward shaders. This will let flags like TAA Reject be useful

* Changelog

* Fix object disappearing from lookdev (#5063)

* Fixed objects disappearing from Lookdev window when entering playmode (case 1309368).

* Updated changelog

* Added hideflags in Lookdev context

* [HDRP] Fix render object after taa jittering (#5088)

* Add a pass after TAA to restore non jittered matrices

* updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix GC alloc in hd/bugfix branch (#5134)

* Fixed GC alloc on hd/bugfix branch

* Fix GC alloc again

* Fix refraction tile artifacts near reflection probe edges (#4727)

* Pick the right probe at object center instead of tile granularity.

* changelog

* Missing commit

* Move stuff in lightloop and out of prelightData

* Update LightLoop.hlsl

* Formatting

Co-authored-by: sebastienlagarde <[email protected]>

* Fix camera rotation uncontrollable with low framerate (#5076)

* Fix camera rotation uncontrollable with low framerate.

* updated changelog

* Clearing out render targets and randmo write targets on pipeline destruction (#5176)

Changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed a null ref exception when adding a new environment to the library. (#5131)

* Fixed a null ref exception when adding a new environment to the library.

* Update changelog

Co-authored-by: sebastienlagarde <[email protected]>

* FogBugz#1348462 - Wait for accessing the HDProjectSettings instance as it was before. (#5141)

* Fix nullref in volume system after deleting a volume object (#5161)

* Fix nullref in volume system after deleting a volume object (case 1348374)

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix APV UI loosing focus when changing a param (#5219)

* Fixed the APV UI losing focus when the helpbox about baking appears in the probe volume.

* Small changes (#5220)

* Fix update order in Graphics Compositor causing jumpy camera updates (#5235)

* Prevent material from having infinite intensity (#5132)

* Prevent material from having infinite intensity

* Fix switching from ldr to hdr emissive

* Fix input field precision

* Round the max value

* Make two variables

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Adding limitations of decal emissive positive contribution to the documentation (#5237)

* Add emissive positive contribution limitation to the doc

* changelog

* Update CHANGELOG.md

* Update Decal-Projector.md

* Update Decal-Shader.md

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix issue with path tracing when switching between non-persistent cameras (#5246)

* Fix issue with path traceing accumulation when switching between cameras.

* Check if camera history is persistent

Co-authored-by: sebastienlagarde <[email protected]>

* removed undesired files

* Fix log base (#5260)

* [HDRP] Fixed mask value stored by the LayerMaskParameter class (#5250)

* Fixed value stored by the layer mask parameter class.

* Updated changelog.

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP][DXR] Make vertex color default to 1.0 instead of 0.0 (#5268)

* When raytracing, make vertex color default to white if not present.

* Updated Changelog.

* Added comment.

* Fix issue with 0-sized dispatch with extremely low resolutions (#5272)

* Ceil to int instead.

* changelog

* [HDRP] Fix incorrect light list indexing when TAA is enabled (#5287)

* Fix incorrect light list indexing when TAA is enabled

* Better handle XR

Co-authored-by: sebastienlagarde <[email protected]>

* Fix incorrect additiona velocity for alembic (#5304)

* Fixed LUT initialization in Wireframe mode (#5156)

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] [LightExplorer] Fix missing refreshwhen editing property with a running paused editor. (#5321)

* Update HDLightExplorerExtension.cs

* Update CHANGELOG.md

* Changed Ambient Mode to Dynamic by default (#5350)

* Visual Environment component ambient mode now defaults to Dynamic.

* Update changelog

* Updated test scene with correct ambient mode after the change

* Missing files

* Last scene fix

* Hd/fix framesettings ordering (#5323)

* Fix strange entry in the FrameSettings and add comments for better readability

* Update CHANGELOG.md

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Bugfix 1357311: Fixed old ray tracing material conversion (#5364)

* - fixed crash in material conversion where material used old raytracing render queue (3900)

* - changelog update

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Bugfix 1358480: Fixed missing tooltip for "Tessellation Mode" (#5365)

* - fixed missing "Tessellation Mode" tooltip

* - update changelog

* - updated "Tessellation Mode" tooltip

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix HD template (particularly visible in path tracing) (#5319)

* Made the 3 light bulbs non shadow-casting.

* Revert "Made the 3 light bulbs non shadow-casting."

This reverts commit f32ba7d.

* Changed bulb prefab (shadow caster off).

* Revert: Changed Ambient Mode to Dynamic by default #5350

* Fixed a null ref exception when no opaque objects are rendered. (#5463)

* Fixed a null ref exception when no opaque objects are rendered.

* Update changelog

* Fix slope scale depth bias when depth offset is ON (#5466)

* Fix slope scale bias being broken when depth offset was enabled

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Fix spot shadow sampling when using custom spot angle (#5439)

* Fixed shadow sampling artifact when using the spot light shadow option 'custom spot angle'

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix darkening in SSR fade  (#5472)

* Fix

* Changelog

Co-authored-by: sebastienlagarde <[email protected]>

* [HDRP] Improve path traced subsurface scattering for transmissive surfaces (#5485)

* Improve subsurface scatering for transmissive surfaces

* Add changelog + fix throughput multiplication

Co-authored-by: sebastienlagarde <[email protected]>

* Fix missing context menu for 'Post Anti-Aliasing' in Camera (1357283) (#5497)

Co-authored-by: sebastienlagarde <[email protected]>

* Force allocate texture if no fallback is available (#5130)

Co-authored-by: sebastienlagarde <[email protected]>

* Update path tracer screenshots

* Update 2314_Shadow_CustonAngle.png

* Fix range compression factor clamping (#5892)

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed tooltip not showing on labels in ShaderGraphs (#5877)

Co-authored-by: sebastienlagarde <[email protected]>

* Proper format for copy history (#5796)

* Fix shadow mask fade and optimize it at same time  (#5911)

* Fix shadow mask fade and optimize.

* changelog

* Fix wrong format for contact shadows and shadow atlas default textures  (#5912)

* Fix contact shadows not being bound in debug and good default shadow

* changelog

* Rename

* Handle more edge cases where shadows are not drawn to atlas (disabled scene view lighting)

Co-authored-by: John Parsaie <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>

* Fixed an issue where probe being forced realtime would cause perf to degrade greatly when manipulating them in editor. (#5901)

* Mark anchor override as not supported for probes (#5939)

* Revert: Fix shadow mask fade and optimize it at same time #5911

* Add info on After post-process info box (#6125)

* Add info on info box

* Clarify a bit better

* Dynamic Ambient improvement and doc update (#5951)

* Avoided unnecessary ambient probe updates

Updated doc with dynamic ambient probe limitations

* Update Environment-Lighting.md

Co-authored-by: sebastienlagarde <[email protected]>

* [SRP] Fix issue when changing volume profiles at runtime with a script (#5882)

* Fix issue when changing volume profiles in runtime with a script

* Add new kine in changelog

* Improve comment

* Changelog typo

Co-authored-by: sebastienlagarde <[email protected]>

* Fix NaN on Intel GPU when using PBR Sky and rendering sun disk  (#6145)

* Enable debug symbols

* tentative

* test using cos from cpu

* Finalize fix

* Missing file

* Remove debug symbols.

* Fix Luminance/EV conversion when LightMeterCalibrationConstant is changed (#6115)

* Fix formmating

* Focus distance in path traced depth of field now takes into account the focus mode setting

* Rename the old test scene to 5006_PathTracing_DofVolume

* Bump up the test number

* Update whats-new-12.md

Co-authored-by: FrancescoC-unity <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>
Co-authored-by: John Parsaie <[email protected]>
Co-authored-by: anisunity <[email protected]>
Co-authored-by: Antoine Lelievre <[email protected]>
Co-authored-by: CifaCia <[email protected]>
Co-authored-by: Adrien de Tocqueville <[email protected]>
Co-authored-by: slunity <[email protected]>
Co-authored-by: Remi Chapelain <[email protected]>
Co-authored-by: Emmanuel Turquin <[email protected]>
Co-authored-by: Adrian1066 <[email protected]>
Co-authored-by: Kleber Garcia <[email protected]>
Co-authored-by: Julien Ignace <[email protected]>
Co-authored-by: alex-vazquez <[email protected]>
Co-authored-by: Rémi Chapelain <[email protected]>
Co-authored-by: Remi Slysz <[email protected]>
Co-authored-by: Jarkko Lempiäinen <[email protected]>

* Fix MSAA resolve of stencil buffer  (#6251)

* Fix resolve

* changelog

Co-authored-by: sebastienlagarde <[email protected]>

* Fix HDRP template input not working when using the new Input System and no Keyboard/Mouse #6045

* Update Materials

* Update 5014_PathTracing_DoubleSidedOverride.png.meta

* Fix shader warning on vulkan

* Fixing ps4 light list build (#6258)

* Fix warning

* Update package.json

* Formatting

* update screenshots

Co-authored-by: anisunity <[email protected]>
Co-authored-by: Pavlos Mavridis <[email protected]>
Co-authored-by: Kleber Garcia <[email protected]>
Co-authored-by: Adrien de Tocqueville <[email protected]>
Co-authored-by: JulienIgnace-Unity <[email protected]>
Co-authored-by: Vic Cooper <[email protected]>
Co-authored-by: Rémi Chapelain <[email protected]>
Co-authored-by: FrancescoC-unity <[email protected]>
Co-authored-by: John Parsaie <[email protected]>
Co-authored-by: Antoine Lelievre <[email protected]>
Co-authored-by: CifaCia <[email protected]>
Co-authored-by: slunity <[email protected]>
Co-authored-by: Remi Chapelain <[email protected]>
Co-authored-by: Emmanuel Turquin <[email protected]>
Co-authored-by: Adrian1066 <[email protected]>
Co-authored-by: alex-vazquez <[email protected]>
Co-authored-by: Remi Slysz <[email protected]>
Co-authored-by: Jarkko Lempiäinen <[email protected]>
Co-authored-by: robinb-u3d <[email protected]>
@ValGrimm-U3D ValGrimm-U3D mentioned this pull request Feb 2, 2022
Closed
ValGrimm-U3D added a commit that referenced this pull request Feb 4, 2022
@ValGrimm-U3D
Update Environment Lighting doc
cfbfb8c 
The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.
@ValGrimm-U3D ValGrimm-U3D mentioned this pull request Feb 4, 2022
Merged
ValGrimm-U3D added a commit that referenced this pull request Feb 8, 2022
@ValGrimm-U3D
Update Environment Lighting doc (#7008)
bf2a628 
The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.
sebastienlagarde pushed a commit that referenced this pull request Feb 8, 2022
@ValGrimm-U3D @sebastienlagarde
Update Environment Lighting doc (#7008)
9638dbc 
The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.
sebastienlagarde added a commit that referenced this pull request Feb 8, 2022
@sebastienlagarde @emilybrown1
@ValGrimm-U3D @TomasKiniulis @JulienIgnace-Unity @FrancescoC-unity @kecho
[HDRP] Backport various PRs (#7054)
48c44f4 
* Update Light Anchor page (#6955)

* Updated Light Anchor to match Core RP page

* added light anchor page to ToC

* Update light-anchor.md

* Update Environment Lighting doc (#7008)

The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.

* Disable main camera in compositor scene (#7038)

* Fixed various issues with render graph viewer when entering playmode. #7040

* Fix for Final Image Histogram debug mode not working on some hardware #7041

* Fixed HDRP camera debug panel rendering foldout. (#7043)

* ** Whats new light loop information ** (#7047)

* Grammar

* Formatting

* Correct version

* [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052)

* update what's new and upgrade guide

* move upgrade guide

* Update Upgrading-from-2021.1-to-2021.2.md

* Update Upgrading-from-2022.1-to-2022.2.md

Co-authored-by: sebastienlagarde <[email protected]>

* removed duplicated sentence (#6999)

* removed italics, fixed notes (#7021)

* removed italics, fixed notes

* Apply formatting changes

Co-authored-by: [email protected] <[email protected]>

* recommended import settings (#7023)

* api formatting (#7027)

* Updated Light Anchor page in line with updated HDRP page (#6956)

* Updated Light Anchor page in line with updated HDRP page

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Apply formatting changes

Co-authored-by: [email protected] <[email protected]>

Co-authored-by: emilybrown1 <[email protected]>
Co-authored-by: Val Grimm <[email protected]>
Co-authored-by: TomasKiniulis <[email protected]>
Co-authored-by: JulienIgnace-Unity <[email protected]>
Co-authored-by: FrancescoC-unity <[email protected]>
Co-authored-by: Kleber Garcia <[email protected]>
Co-authored-by: Antoine Lelievre <[email protected]>
Co-authored-by: [email protected] <[email protected]>
sebastienlagarde added a commit that referenced this pull request Feb 8, 2022
@sebastienlagarde @emilybrown1
@ValGrimm-U3D @TomasKiniulis @JulienIgnace-Unity @FrancescoC-unity @kecho
[HDRP] Backport various PRs (#7054)
01c3a39 
* Update Light Anchor page (#6955)

* Updated Light Anchor to match Core RP page

* added light anchor page to ToC

* Update light-anchor.md

* Update Environment Lighting doc (#7008)

The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.

* Disable main camera in compositor scene (#7038)

* Fixed various issues with render graph viewer when entering playmode. #7040

* Fix for Final Image Histogram debug mode not working on some hardware #7041

* Fixed HDRP camera debug panel rendering foldout. (#7043)

* ** Whats new light loop information ** (#7047)

* Grammar

* Formatting

* Correct version

* [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052)

* update what's new and upgrade guide

* move upgrade guide

* Update Upgrading-from-2021.1-to-2021.2.md

* Update Upgrading-from-2022.1-to-2022.2.md

Co-authored-by: sebastienlagarde <[email protected]>

* removed duplicated sentence (#6999)

* removed italics, fixed notes (#7021)

* removed italics, fixed notes

* Apply formatting changes

Co-authored-by: [email protected] <[email protected]>

* recommended import settings (#7023)

* api formatting (#7027)

* Updated Light Anchor page in line with updated HDRP page (#6956)

* Updated Light Anchor page in line with updated HDRP page

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Apply formatting changes

Co-authored-by: [email protected] <[email protected]>

Co-authored-by: emilybrown1 <[email protected]>
Co-authored-by: Val Grimm <[email protected]>
Co-authored-by: TomasKiniulis <[email protected]>
Co-authored-by: JulienIgnace-Unity <[email protected]>
Co-authored-by: FrancescoC-unity <[email protected]>
Co-authored-by: Kleber Garcia <[email protected]>
Co-authored-by: Antoine Lelievre <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JMargevics JMargevics JMargevics approved these changes

+2 more reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@ValGrimm-U3D ValGrimm-U3D ValGrimm-U3D approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-2021.2 HDRP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JulienIgnace-Unity @ValGrimm-U3D @sebastienlagarde @JMargevics