Fixed support of distortion with MSAA #4711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
Contributor
Author
|
note: I will merge this PR for the SRP2Core cutoff it is pretty safe and yamato is green. |
JMargevics
reviewed
Jun 2, 2021
Contributor
JMargevics
left a comment
JMargevics
left a comment
There was a problem hiding this comment.
Verified from my side on bugfix branch. Distortion looks good with MSAA enabled. Tested on DX11, DX12 and Vulkan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR re-enable the support of distortion with MSAA which were disabled. It looks like RenderGraph change allowed the support.
Testing status
Tested in a scene that distortion is working the same way with or without MSAA
Comments to reviewers
Notes for the reviewers you have assigned.