Hd/fix framesettings ordering #5323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix https://fogbugz.unity3d.com/f/cases/1355836/
Several PR have landed on the ProbeVolume. One of it added an hidding mechanisme. I am not fond of it as it may be more difficult now to add a new framesettings as we have some dynamically hidden. And this is also not compatible with the current UX workflow. But I understand the needs for this as it is experimental.
Then another FrameSettings was added with a dependency on the hidden one. But it was not hidden itself. So usual case, when the feature flag is disable, you have the dependant shown indented under somecing that have no relation with it (see below)

The fix here do:
Testing status
Manually tested the hidding (see screenshot above)
Comments to reviewers
@FrancescoC-unity Have your PRs been backported ?