Skip to content

Fixed various issues with render graph viewer when entering playmode. #7040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 8, 2022
Merged

Fixed various issues with render graph viewer when entering playmode. #7040

merged 4 commits into from
Feb 8, 2022

Conversation

@JulienIgnace-Unity
Copy link
Contributor

@JulienIgnace-Unity JulienIgnace-Unity commented Feb 8, 2022

Purpose of this PR

Fixed various issues with render graph viewer when entering playmode.

Testing status

Tested the repro in the package verification doc.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

RemyUnity
RemyUnity approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@RemyUnity RemyUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@sebastienlagarde sebastienlagarde merged commit 647271b into master Feb 8, 2022
@sebastienlagarde sebastienlagarde deleted the hd/fix-rendergraph-viewer-playmode branch February 8, 2022 16:05
sebastienlagarde pushed a commit that referenced this pull request Feb 8, 2022
@JulienIgnace-Unity @sebastienlagarde
Fixed various issues with render graph viewer when entering playmode. #…
4fa99b2 
…7040
@sebastienlagarde sebastienlagarde mentioned this pull request Feb 8, 2022
Merged
sebastienlagarde added a commit that referenced this pull request Feb 8, 2022
@sebastienlagarde @emilybrown1
@ValGrimm-U3D @TomasKiniulis @JulienIgnace-Unity @FrancescoC-unity @kecho
[HDRP] Backport various PRs (#7054)
48c44f4 
* Update Light Anchor page (#6955)

* Updated Light Anchor to match Core RP page

* added light anchor page to ToC

* Update light-anchor.md

* Update Environment Lighting doc (#7008)

The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.

* Disable main camera in compositor scene (#7038)

* Fixed various issues with render graph viewer when entering playmode. #7040

* Fix for Final Image Histogram debug mode not working on some hardware #7041

* Fixed HDRP camera debug panel rendering foldout. (#7043)

* ** Whats new light loop information ** (#7047)

* Grammar

* Formatting

* Correct version

* [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052)

* update what's new and upgrade guide

* move upgrade guide

* Update Upgrading-from-2021.1-to-2021.2.md

* Update Upgrading-from-2022.1-to-2022.2.md

Co-authored-by: sebastienlagarde <[email protected]>

* removed duplicated sentence (#6999)

* removed italics, fixed notes (#7021)

* removed italics, fixed notes

* Apply formatting changes

Co-authored-by: [email protected] <[email protected]>

* recommended import settings (#7023)

* api formatting (#7027)

* Updated Light Anchor page in line with updated HDRP page (#6956)

* Updated Light Anchor page in line with updated HDRP page

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Apply formatting changes

Co-authored-by: [email protected] <[email protected]>

Co-authored-by: emilybrown1 <[email protected]>
Co-authored-by: Val Grimm <[email protected]>
Co-authored-by: TomasKiniulis <[email protected]>
Co-authored-by: JulienIgnace-Unity <[email protected]>
Co-authored-by: FrancescoC-unity <[email protected]>
Co-authored-by: Kleber Garcia <[email protected]>
Co-authored-by: Antoine Lelievre <[email protected]>
Co-authored-by: [email protected] <[email protected]>
sebastienlagarde added a commit that referenced this pull request Feb 8, 2022
@sebastienlagarde @emilybrown1
@ValGrimm-U3D @TomasKiniulis @JulienIgnace-Unity @FrancescoC-unity @kecho
[HDRP] Backport various PRs (#7054)
01c3a39 
* Update Light Anchor page (#6955)

* Updated Light Anchor to match Core RP page

* added light anchor page to ToC

* Update light-anchor.md

* Update Environment Lighting doc (#7008)

The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.

* Disable main camera in compositor scene (#7038)

* Fixed various issues with render graph viewer when entering playmode. #7040

* Fix for Final Image Histogram debug mode not working on some hardware #7041

* Fixed HDRP camera debug panel rendering foldout. (#7043)

* ** Whats new light loop information ** (#7047)

* Grammar

* Formatting

* Correct version

* [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052)

* update what's new and upgrade guide

* move upgrade guide

* Update Upgrading-from-2021.1-to-2021.2.md

* Update Upgrading-from-2022.1-to-2022.2.md

Co-authored-by: sebastienlagarde <[email protected]>

* removed duplicated sentence (#6999)

* removed italics, fixed notes (#7021)

* removed italics, fixed notes

* Apply formatting changes

Co-authored-by: [email protected] <[email protected]>

* recommended import settings (#7023)

* api formatting (#7027)

* Updated Light Anchor page in line with updated HDRP page (#6956)

* Updated Light Anchor page in line with updated HDRP page

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Apply formatting changes

Co-authored-by: [email protected] <[email protected]>

Co-authored-by: emilybrown1 <[email protected]>
Co-authored-by: Val Grimm <[email protected]>
Co-authored-by: TomasKiniulis <[email protected]>
Co-authored-by: JulienIgnace-Unity <[email protected]>
Co-authored-by: FrancescoC-unity <[email protected]>
Co-authored-by: Kleber Garcia <[email protected]>
Co-authored-by: Antoine Lelievre <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RemyUnity RemyUnity RemyUnity approved these changes

+1 more reviewer

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-2021.2 backported-2022.1 HDRP SRP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JulienIgnace-Unity @sebastienlagarde @RemyUnity