Skip to content

Conversation

@RSlysz
Copy link
Contributor

@RSlysz RSlysz commented Aug 9, 2021

Purpose of this PR

Fix https://fogbugz.unity3d.com/f/cases/1354129/
(Missing refresh of scene view when changing light in LightExplorer and editor is in run and paused.

FB is for ContactShadow but the same also apply to affectDiffuse and affectSpecular (also fixed here)


Testing status

Manually tested (now we see the change in sceneview while editing from the LightExplorer). Tested with the directional light (sun) in the hd template while looking at the tree.


Comments to reviewers

Note: only appears when running and pausing the game.

@github-actions
Copy link

github-actions bot commented Aug 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Aug 9, 2021
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@RSlysz RSlysz requested a review from a team August 9, 2021 20:28
@RSlysz RSlysz changed the title Hd/fix lightexplorer sceneview refresh [HDRP] [LightExplorer] Fix missing refreshwhen editing property with a running paused editor. Aug 9, 2021
Copy link
Contributor

@RemyUnity RemyUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me ! 🟢

@RSlysz RSlysz removed the request for review from FrancescoC-unity August 10, 2021 11:02
@JulienIgnace-Unity JulienIgnace-Unity merged commit b306e57 into hd/bugfix Aug 10, 2021
@JulienIgnace-Unity JulienIgnace-Unity deleted the hd/fix-lightexplorer-sceneview-refresh branch August 10, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants