Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-proxy-middleware): refactoring of directLoad implementation #2319

Merged
merged 21 commits into from
Sep 5, 2024

Conversation

ytpo-lyne
Copy link
Contributor

Fix for: #2225
directLoad: true does not work and fails with Error: EISDIR: illegal operation on a directory, read.

Changes:

  • replaced req.baseUrl object with req.url
  • uses the rootProject reference provided by cli
  • removes hardcoded endpoint names
  • readMe update for virtual endpoints

@ytpo-lyne ytpo-lyne added the ui5-proxy-middleware @sap-ux/ui5-proxy-middleware label Sep 4, 2024
Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 6f2602e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/ui5-proxy-middleware Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ytpo-lyne ytpo-lyne marked this pull request as ready for review September 4, 2024 08:59
@ytpo-lyne ytpo-lyne requested a review from a team as a code owner September 4, 2024 08:59
Copy link

sonarcloud bot commented Sep 4, 2024

Copy link
Contributor

@tobiasqueck tobiasqueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changeset ok
  • clean and well structured coding
  • nice cleanup of the tests
  • successfully locally tested after the last change to src

Copy link
Contributor

@815are 815are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked:

  1. code - changes easy to read, did not notice issue
  2. unit tests are maintained

did not test locally

@ytpo-lyne ytpo-lyne merged commit 8aa367a into main Sep 5, 2024
13 checks passed
@ytpo-lyne ytpo-lyne deleted the fix/2225/directLoad-and-more branch September 5, 2024 06:53
devinea added a commit that referenced this pull request Sep 5, 2024
* origin/main: (38 commits)
  chore: apply latest changesets
  feat: Refactor and enhance Launch Configuration Logic for debugging generated apps in @sap-ux/launch-config (#2274)
  chore: apply latest changesets
  fix(ui5-proxy-middleware): refactoring of directLoad implementation (#2319)
  chore: apply latest changesets
  fix(cpe): outline tree scroll bar (#2283)
  chore: apply latest changesets
  feat: quick actions (#2142)
  chore: apply latest changesets
  feat(fe-fpm-writer): apply context path to a building block based on min ui5 version (#2312)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): remove inquirer package (#2318)
  chore: apply latest changesets
  fix(cf-deploy-config-writer): refactor hasUI5CliV3 to project-access for common reuse (#2313)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): add missing dependencies (#2314)
  chore: apply latest changesets
  fix(odata-service-inquirer): #2309 fix for annotations not retrieved using service url prompt (#2310)
  chore: apply latest changesets
  fix: adjustment of the color of chevron on selection (#2303)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui5-proxy-middleware @sap-ux/ui5-proxy-middleware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants