-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-proxy-middleware): refactoring of directLoad implementation #2319
Conversation
🦋 Changeset detectedLatest commit: 6f2602e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- changeset ok
- clean and well structured coding
- nice cleanup of the tests
- successfully locally tested after the last change to
src
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked:
- code - changes easy to read, did not notice issue
- unit tests are maintained
did not test locally
* origin/main: (38 commits) chore: apply latest changesets feat: Refactor and enhance Launch Configuration Logic for debugging generated apps in @sap-ux/launch-config (#2274) chore: apply latest changesets fix(ui5-proxy-middleware): refactoring of directLoad implementation (#2319) chore: apply latest changesets fix(cpe): outline tree scroll bar (#2283) chore: apply latest changesets feat: quick actions (#2142) chore: apply latest changesets feat(fe-fpm-writer): apply context path to a building block based on min ui5 version (#2312) chore: apply latest changesets fix(abap-deploy-config-inquirer ): remove inquirer package (#2318) chore: apply latest changesets fix(cf-deploy-config-writer): refactor hasUI5CliV3 to project-access for common reuse (#2313) chore: apply latest changesets fix(abap-deploy-config-inquirer ): add missing dependencies (#2314) chore: apply latest changesets fix(odata-service-inquirer): #2309 fix for annotations not retrieved using service url prompt (#2310) chore: apply latest changesets fix: adjustment of the color of chevron on selection (#2303) ...
Fix for: #2225
directLoad: true
does not work and fails withError: EISDIR: illegal operation on a directory, read
.Changes:
req.baseUrl
object withreq.url
rootProject
reference provided by cli