Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cf-deploy-config-writer): refactor hasUI5CliV3 to project-access for common reuse #2313

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

longieirl
Copy link
Contributor

@longieirl longieirl commented Sep 2, 2024

Fix for #2007

  • Move method hasUI5CliV3 to allow be resuse in other modules
  • Required in the cf writer to determine if the dependencies being added should also be added to the ui5 dependencies.

@longieirl longieirl self-assigned this Sep 2, 2024
@longieirl longieirl requested review from a team as code owners September 2, 2024 10:24
Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: ec00bbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@sap-ux/odata-service-writer Patch
@sap-ux/project-access Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/adp-tooling Patch
@sap-ux/annotation-generator Patch
@sap-ux/app-config-writer Patch
@sap-ux/cap-config-writer Patch
@sap-ux/cards-editor-middleware Patch
@sap-ux/create Patch
@sap-ux/environment-check Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/launch-config Patch
@sap-ux/preview-middleware Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/abap-deploy-config-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@kjose90 kjose90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @longieirl

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. changeset ✅

Copy link

sonarcloud bot commented Sep 3, 2024

@longieirl longieirl merged commit d962ce1 into main Sep 3, 2024
13 checks passed
@longieirl longieirl deleted the feature/2007/expose-cliv3-validation branch September 3, 2024 18:54
devinea added a commit that referenced this pull request Sep 5, 2024
* origin/main: (38 commits)
  chore: apply latest changesets
  feat: Refactor and enhance Launch Configuration Logic for debugging generated apps in @sap-ux/launch-config (#2274)
  chore: apply latest changesets
  fix(ui5-proxy-middleware): refactoring of directLoad implementation (#2319)
  chore: apply latest changesets
  fix(cpe): outline tree scroll bar (#2283)
  chore: apply latest changesets
  feat: quick actions (#2142)
  chore: apply latest changesets
  feat(fe-fpm-writer): apply context path to a building block based on min ui5 version (#2312)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): remove inquirer package (#2318)
  chore: apply latest changesets
  fix(cf-deploy-config-writer): refactor hasUI5CliV3 to project-access for common reuse (#2313)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): add missing dependencies (#2314)
  chore: apply latest changesets
  fix(odata-service-inquirer): #2309 fix for annotations not retrieved using service url prompt (#2310)
  chore: apply latest changesets
  fix: adjustment of the color of chevron on selection (#2303)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants