Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe-fpm-writer): apply context path to a building block based on min ui5 version #2312

Conversation

AlinaGovoruhina
Copy link
Contributor

@AlinaGovoruhina AlinaGovoruhina commented Sep 2, 2024

Apply contextPath for minimum UI5 versions equal or below 1.96 ( + always for chart building block).
Check for minimum UI5 version when applying the building block and when getting the code snippet content.

Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: 3fd2d96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sap-ux/fe-fpm-writer Minor
@sap-ux/fiori-elements-writer Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlinaGovoruhina AlinaGovoruhina marked this pull request as ready for review September 2, 2024 09:00
@AlinaGovoruhina AlinaGovoruhina requested a review from a team as a code owner September 2, 2024 09:00
Copy link
Contributor

@815are 815are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked:

  1. code is simple to understand and version check conditions fulfil expectation;
  2. new tests are added
  3. changeset presented

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes and tests look good.
changeset ✅

Copy link

sonarcloud bot commented Sep 4, 2024

@AlinaGovoruhina AlinaGovoruhina merged commit 177cdc8 into main Sep 4, 2024
13 checks passed
@AlinaGovoruhina AlinaGovoruhina deleted the feat/fe-fpm-writer/context-path-for-ui5-lte-1-96-building-block branch September 4, 2024 10:20
devinea added a commit that referenced this pull request Sep 5, 2024
* origin/main: (38 commits)
  chore: apply latest changesets
  feat: Refactor and enhance Launch Configuration Logic for debugging generated apps in @sap-ux/launch-config (#2274)
  chore: apply latest changesets
  fix(ui5-proxy-middleware): refactoring of directLoad implementation (#2319)
  chore: apply latest changesets
  fix(cpe): outline tree scroll bar (#2283)
  chore: apply latest changesets
  feat: quick actions (#2142)
  chore: apply latest changesets
  feat(fe-fpm-writer): apply context path to a building block based on min ui5 version (#2312)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): remove inquirer package (#2318)
  chore: apply latest changesets
  fix(cf-deploy-config-writer): refactor hasUI5CliV3 to project-access for common reuse (#2313)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): add missing dependencies (#2314)
  chore: apply latest changesets
  fix(odata-service-inquirer): #2309 fix for annotations not retrieved using service url prompt (#2310)
  chore: apply latest changesets
  fix: adjustment of the color of chevron on selection (#2303)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants