BUG - @sap-ux/ui5-proxy-middleware directLoad not working

[zinserjan]

Related Feature

Feature request: -

Description

• directLoad: true does not work and fails with Error: EISDIR: illegal operation on a directory, read

Steps to Reproduce

Steps to reproduce the behavior:

1. use directLoad: true in @sap-ux/ui5-proxy-middleware
2. Open /index.html or /test/flpSandbox.html
3. See error

Expected results

• no Error
• URLs are replaced

Actual results

• Error: EISDIR: illegal operation on a directory, read

Version/Components/Environment

Add any other context about the problem here

OS:

• Mac OS
• Windows
• Other

Node.js v20.16.0

Packages:

• @ui5/cli v4.0.3
• @sap-ux/ui5-proxy-middleware v1.4.3

Root Cause Analysis

Problem

• req.baseUrl is here always an empty string

  open-ux-tools/packages/ui5-proxy-middleware/src/base/utils.ts

  Lines 275 to 280 in c0f9298

  	const htmlFileName = getHtmlFile(req.baseUrl);
  	const yamlFileName = getYamlFile(args);
  	const ui5YamlPath = join(projectRoot, yamlFileName);
  	const webAppFolder = await getWebAppFolderFromYaml(ui5YamlPath);
  	const htmlFilePath = join(projectRoot, webAppFolder, htmlFileName);
  	const html = injectUI5Url(htmlFilePath, ui5Configs);

• htmlFilePath will be just the webapp folder instead of the path to the requested HTML file
• that's why the further logic doesn't work and instead of replacing the URL in injectUI5Url it tries to read the webapp directory

Fix

• just use reg.url or reg.originalUrl

[tobiasqueck]

@cfg74 could you please plan to get this one fixed.