feat: Refactor and enhance Launch Configuration Logic for debugging generated apps in @sap-ux/launch-config #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 712bb26 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kjose90
changed the title
kjose90
changed the title
…tools into debug-launch-config
longieirl
reviewed
Sep 4, 2024
devinea
previously approved these changes
Sep 4, 2024
|
longieirl
approved these changes
Sep 5, 2024
|
Thanks for reviewing 👍 |
devinea
added a commit
that referenced
this pull request
Sep 5, 2024
* origin/main: (38 commits) chore: apply latest changesets feat: Refactor and enhance Launch Configuration Logic for debugging generated apps in @sap-ux/launch-config (#2274) chore: apply latest changesets fix(ui5-proxy-middleware): refactoring of directLoad implementation (#2319) chore: apply latest changesets fix(cpe): outline tree scroll bar (#2283) chore: apply latest changesets feat: quick actions (#2142) chore: apply latest changesets feat(fe-fpm-writer): apply context path to a building block based on min ui5 version (#2312) chore: apply latest changesets fix(abap-deploy-config-inquirer ): remove inquirer package (#2318) chore: apply latest changesets fix(cf-deploy-config-writer): refactor hasUI5CliV3 to project-access for common reuse (#2313) chore: apply latest changesets fix(abap-deploy-config-inquirer ): add missing dependencies (#2314) chore: apply latest changesets fix(odata-service-inquirer): #2309 fix for annotations not retrieved using service url prompt (#2310) chore: apply latest changesets fix: adjustment of the color of chevron on selection (#2303) ...
IainSAP
reviewed
Sep 9, 2024
| @@ -34,6 +34,9 @@ | |||
| "@sap-ux/project-access": "workspace:*", | |||
| "@sap-ux/ui5-config": "workspace:*", | |||
| "@sap-ux/ui5-info": "workspace:*", | |||
| "@sap-ux/odata-service-inquirer": "workspace:*", | |||
There was a problem hiding this comment.
Please remove this dependency, this is using types not intended for this purpose and should only be consumed if you are calling getPrompts or prompt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation will focus on managing various workspace scenarios, including unsaved workspaces, folders without workspace files, and saved workspaces so users can seamlessly debug the generated application, regardless of their workspace configuration.
debug-config/workspaceManager.tsManages the configuration of the debug workspace based on the provided options.
It handles different scenarios such as whether a workspace is open, whether the project is inside or outside of a workspace, and other contextual factors.
handleWorkspaceConfigreturnsWorkspaceHandlerInfo, an object containing:1. The path where the
launch.jsonfile will be written.2. The
cwdcommand, determined by workspace settings.3.
workspaceFolderUri, if provided, which facilitates workspace reloading.debug-config/config.tsGenerates the contents of the
launch.jsonfile based on the options provided.configureLaunchJsonFilereturns the configuredlaunch.jsonobject, tailored to the specified debug options and cwd command.launch-config-crud/create.tsHandles the creation of the launch configuration for the project based on the provided debug options.
configureLaunchConfiggenerates and creates thelaunch.jsonfile.If
workspaceFolderUriis provided, it creates thelaunch.json file, triggers a workspace reload, and updates theappInfo.jsonfile with the current project path. This ensures the App Info page is correctly loaded post-reload.Add unit tests