Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quick actions #2142

Merged
merged 103 commits into from
Sep 4, 2024
Merged

feat: quick actions #2142

merged 103 commits into from
Sep 4, 2024

Conversation

voicis
Copy link
Contributor

@voicis voicis commented Jul 11, 2024

Enable Quick Action List in CPE for Adaptation editor.
LR/ALP
Enable Clear button in the filter bar
Extend a page with an own controller
Change table columns

Object Page:
Change table columns
Extend a page with an own controller

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: 401efb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sap-ux-private/control-property-editor-common Minor
@sap-ux-private/preview-middleware-client Minor
@sap-ux/control-property-editor Minor
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Jimmy-Joseph19 Jimmy-Joseph19 self-assigned this Jul 11, 2024
marufrasully
marufrasully previously approved these changes Sep 2, 2024
Copy link
Contributor

@marufrasully marufrasully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed following packages

  • @sap-ux-private/control-property-editor-common
  • @sap-ux/control-property-editor
    Changes looks good. Did not test it locally.

Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the following

  • description of the PR (changes)
  • the link to the issue

Otherwise, the code looks good. Still need to test this locally.

Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good
Coverage is OK
Previewed locally but did not test

Copy link
Contributor

@marufrasully marufrasully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed following packages

  • @sap-ux-private/control-property-editor-common
  • @sap-ux/control-property-editor
    Changes looks good. Did not test it locally.

Copy link

sonarcloud bot commented Sep 4, 2024

@Jimmy-Joseph19 Jimmy-Joseph19 merged commit b1628da into main Sep 4, 2024
13 checks passed
@Jimmy-Joseph19 Jimmy-Joseph19 deleted the feat/cpe-quick-actions branch September 4, 2024 10:57
devinea added a commit that referenced this pull request Sep 5, 2024
* origin/main: (38 commits)
  chore: apply latest changesets
  feat: Refactor and enhance Launch Configuration Logic for debugging generated apps in @sap-ux/launch-config (#2274)
  chore: apply latest changesets
  fix(ui5-proxy-middleware): refactoring of directLoad implementation (#2319)
  chore: apply latest changesets
  fix(cpe): outline tree scroll bar (#2283)
  chore: apply latest changesets
  feat: quick actions (#2142)
  chore: apply latest changesets
  feat(fe-fpm-writer): apply context path to a building block based on min ui5 version (#2312)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): remove inquirer package (#2318)
  chore: apply latest changesets
  fix(cf-deploy-config-writer): refactor hasUI5CliV3 to project-access for common reuse (#2313)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): add missing dependencies (#2314)
  chore: apply latest changesets
  fix(odata-service-inquirer): #2309 fix for annotations not retrieved using service url prompt (#2310)
  chore: apply latest changesets
  fix: adjustment of the color of chevron on selection (#2303)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants