Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - odata-service-inquirer: Annotations not returned for (Abap hosted) odata service urls #2309

Closed
3 tasks
IainSAP opened this issue Aug 31, 2024 · 1 comment
Assignees
Labels
odata-service-inquirer @sap-ux/odata-service-inquirer

Comments

@IainSAP
Copy link
Contributor

IainSAP commented Aug 31, 2024

Description

Where an odata service url prompt is used a best effort attempt is made to retrieve annotations (assuming the service is hosted on an Abap system). Annotations are not retrieved.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected results

Actual results

Screenshots

If applicable, add screenshots to help explain the problem.

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

@IainSAP IainSAP self-assigned this Aug 31, 2024
@IainSAP IainSAP added the odata-service-inquirer @sap-ux/odata-service-inquirer label Aug 31, 2024
@IainSAP IainSAP changed the title BUG - odata-service-inquirer: Annotations not returned for odata service urls BUG - odata-service-inquirer: Annotations not returned for (Abap hosted) odata service urls Aug 31, 2024
longieirl added a commit that referenced this issue Sep 2, 2024
…using service url prompt (#2310)

* fix for annotations not retrieved using service url prompt

#2309

* Update jest.config.js

* Adds cset

---------

Co-authored-by: J Long <[email protected]>
devinea added a commit that referenced this issue Sep 5, 2024
* origin/main: (38 commits)
  chore: apply latest changesets
  feat: Refactor and enhance Launch Configuration Logic for debugging generated apps in @sap-ux/launch-config (#2274)
  chore: apply latest changesets
  fix(ui5-proxy-middleware): refactoring of directLoad implementation (#2319)
  chore: apply latest changesets
  fix(cpe): outline tree scroll bar (#2283)
  chore: apply latest changesets
  feat: quick actions (#2142)
  chore: apply latest changesets
  feat(fe-fpm-writer): apply context path to a building block based on min ui5 version (#2312)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): remove inquirer package (#2318)
  chore: apply latest changesets
  fix(cf-deploy-config-writer): refactor hasUI5CliV3 to project-access for common reuse (#2313)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): add missing dependencies (#2314)
  chore: apply latest changesets
  fix(odata-service-inquirer): #2309 fix for annotations not retrieved using service url prompt (#2310)
  chore: apply latest changesets
  fix: adjustment of the color of chevron on selection (#2303)
  ...
@IainSAP
Copy link
Contributor Author

IainSAP commented Sep 10, 2024

Fixed

@IainSAP IainSAP closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
odata-service-inquirer @sap-ux/odata-service-inquirer
Projects
None yet
Development

No branches or pull requests

1 participant