Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjustment of the color of chevron on selection #2303

Merged
merged 10 commits into from
Sep 2, 2024

Conversation

emrecevik06
Copy link
Contributor

@emrecevik06 emrecevik06 commented Aug 29, 2024

There was a problem with the color of the chevron when selecting in the light theme. When selecting, the chevron was still dark and did not use the color of the text (white).

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 580ddf5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/control-property-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emrecevik06 emrecevik06 marked this pull request as ready for review August 29, 2024 13:07
@emrecevik06 emrecevik06 requested a review from a team as a code owner August 29, 2024 13:07
@emrecevik06 emrecevik06 self-assigned this Aug 30, 2024
Jimmy-Joseph19
Jimmy-Joseph19 previously approved these changes Aug 30, 2024
Copy link
Contributor

@Jimmy-Joseph19 Jimmy-Joseph19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.
Changeset found
Approving

@voicis voicis self-requested a review August 30, 2024 13:45
Copy link

sonarcloud bot commented Sep 2, 2024

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Straight forward style change
  • Review comments addressed
  • Changeset present
  • Tested locally

Copy link
Contributor

@Jimmy-Joseph19 Jimmy-Joseph19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback Changes looks good
Approving

@voicis voicis merged commit 2b6daf3 into main Sep 2, 2024
13 checks passed
@voicis voicis deleted the change-chevron-color-on-selection branch September 2, 2024 14:13
devinea added a commit that referenced this pull request Sep 5, 2024
* origin/main: (38 commits)
  chore: apply latest changesets
  feat: Refactor and enhance Launch Configuration Logic for debugging generated apps in @sap-ux/launch-config (#2274)
  chore: apply latest changesets
  fix(ui5-proxy-middleware): refactoring of directLoad implementation (#2319)
  chore: apply latest changesets
  fix(cpe): outline tree scroll bar (#2283)
  chore: apply latest changesets
  feat: quick actions (#2142)
  chore: apply latest changesets
  feat(fe-fpm-writer): apply context path to a building block based on min ui5 version (#2312)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): remove inquirer package (#2318)
  chore: apply latest changesets
  fix(cf-deploy-config-writer): refactor hasUI5CliV3 to project-access for common reuse (#2313)
  chore: apply latest changesets
  fix(abap-deploy-config-inquirer ): add missing dependencies (#2314)
  chore: apply latest changesets
  fix(odata-service-inquirer): #2309 fix for annotations not retrieved using service url prompt (#2310)
  chore: apply latest changesets
  fix: adjustment of the color of chevron on selection (#2303)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants