Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fe-fpm-writer): apply context path to a building block based on min ui5 version #2312

Merged
merged 18 commits into from
Sep 4, 2024
Merged

feat(fe-fpm-writer): apply context path to a building block based on min ui5 version #2312

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3d3b318
feat: apply context path based on min ui5 version
AlinaGovoruhina Sep 2, 2024
9772607
chore: changeset
AlinaGovoruhina Sep 2, 2024
949bd2d
fix: make context path param mandatory
AlinaGovoruhina Sep 2, 2024
e85aa83
test: update snapshots
AlinaGovoruhina Sep 2, 2024
485b773
fix: jsdoc
AlinaGovoruhina Sep 2, 2024
b799ca3
test: update test manifest with ui5 version
AlinaGovoruhina Sep 2, 2024
612dc18
Merge branch 'main' into feat/fe-fpm-writer/context-path-for-ui5-lte-…
AlinaGovoruhina Sep 2, 2024
1f54dd0
fix: default to high ui5
AlinaGovoruhina Sep 2, 2024
99a78eb
test: check close to 1.96 ui5 versions
AlinaGovoruhina Sep 2, 2024
c4315cc
Merge branch 'feat/fe-fpm-writer/context-path-for-ui5-lte-1-96-buildi…
AlinaGovoruhina Sep 2, 2024
b959bf7
fix: context path for ui5 1.96.
AlinaGovoruhina Sep 3, 2024
2f16486
test: update ui5 version checks
AlinaGovoruhina Sep 3, 2024
9e7b935
Merge branch 'main' into feat/fe-fpm-writer/context-path-for-ui5-lte-…
AlinaGovoruhina Sep 3, 2024
7e89b38
fix: simplify cast
815are Sep 4, 2024
cc51f46
fix: changeset
815are Sep 4, 2024
894acd8
Merge branch 'main' into feat/fe-fpm-writer/context-path-for-ui5-lte-…
devinea Sep 4, 2024
88e61cb
Merge branch 'main' into feat/fe-fpm-writer/context-path-for-ui5-lte-…
AlinaGovoruhina Sep 4, 2024
3fd2d96
Merge branch 'main' into feat/fe-fpm-writer/context-path-for-ui5-lte-…
AlinaGovoruhina Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 70 additions & 11 deletions packages/fe-fpm-writer/test/unit/prompts/__snapshots__/prompts.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,24 +211,21 @@ exports[`Prompts - no project getCodeSnippet Type "chart", get code snippet 1`]
exports[`Prompts - no project getCodeSnippet Type "filter-bar", get code snippet 1`] = `
"<macros:FilterBar
id=\\"id\\"
metaPath=\\"/REPLACE_WITH_A_QUALIFIER\\"
contextPath=\\"REPLACE_WITH_ENTITY\\"
metaPath=\\"/REPLACE_WITH_ENTITY/REPLACE_WITH_A_QUALIFIER\\"
/>"
`;

exports[`Prompts - no project getCodeSnippet Type "table", get code snippet 1`] = `
"<macros:Table
id=\\"id\\"
metaPath=\\"/REPLACE_WITH_A_QUALIFIER\\"
contextPath=\\"REPLACE_WITH_ENTITY\\"
metaPath=\\"/REPLACE_WITH_ENTITY/REPLACE_WITH_A_QUALIFIER\\"
/>"
`;

exports[`Prompts - no project getCodeSnippet get code snippet with placeholders 1`] = `
"<macros:Table
id=\\"REPLACE_WITH_BUILDING_BLOCK_ID\\"
metaPath=\\"/REPLACE_WITH_A_QUALIFIER\\"
contextPath=\\"REPLACE_WITH_ENTITY\\"
metaPath=\\"/REPLACE_WITH_ENTITY/REPLACE_WITH_A_QUALIFIER\\"
type=\\"GridTable\\"
/>"
`;
Expand Down Expand Up @@ -1160,7 +1157,29 @@ exports[`Prompts getCodeSnippet Type "chart", get code snippet 1`] = `
/>"
`;

exports[`Prompts getCodeSnippet Type "chart", get code snippet, min ui5Version = 1.95.0 1`] = `
exports[`Prompts getCodeSnippet Type "chart", get code snippet, min ui5Version = 1.95.35 1`] = `
"<macros:Chart
id=\\"id\\"
metaPath=\\"qualifier\\"
contextPath=\\"/entity\\"
filterBar=\\"filterBar\\"
selectionMode=\\"testSelectionMode\\"
selectionChange=\\"function1\\"
/>"
`;

exports[`Prompts getCodeSnippet Type "chart", get code snippet, min ui5Version = 1.96.0 1`] = `
"<macros:Chart
id=\\"id\\"
metaPath=\\"qualifier\\"
contextPath=\\"/entity\\"
filterBar=\\"filterBar\\"
selectionMode=\\"testSelectionMode\\"
selectionChange=\\"function1\\"
/>"
`;

exports[`Prompts getCodeSnippet Type "chart", get code snippet, min ui5Version = 1.96.25 1`] = `
"<macros:Chart
id=\\"id\\"
metaPath=\\"qualifier\\"
Expand Down Expand Up @@ -1191,7 +1210,7 @@ exports[`Prompts getCodeSnippet Type "filter-bar", get code snippet 1`] = `
/>"
`;

exports[`Prompts getCodeSnippet Type "filter-bar", get code snippet, min ui5Version = 1.95.0 1`] = `
exports[`Prompts getCodeSnippet Type "filter-bar", get code snippet, min ui5Version = 1.95.35 1`] = `
"<macros:FilterBar
id=\\"id\\"
metaPath=\\"qualifier\\"
Expand All @@ -1201,7 +1220,7 @@ exports[`Prompts getCodeSnippet Type "filter-bar", get code snippet, min ui5Vers
/>"
`;

exports[`Prompts getCodeSnippet Type "filter-bar", get code snippet, min ui5Version is undefined 1`] = `
exports[`Prompts getCodeSnippet Type "filter-bar", get code snippet, min ui5Version = 1.96.0 1`] = `
"<macros:FilterBar
id=\\"id\\"
metaPath=\\"qualifier\\"
Expand All @@ -1211,6 +1230,24 @@ exports[`Prompts getCodeSnippet Type "filter-bar", get code snippet, min ui5Vers
/>"
`;

exports[`Prompts getCodeSnippet Type "filter-bar", get code snippet, min ui5Version = 1.96.25 1`] = `
"<macros:FilterBar
id=\\"id\\"
metaPath=\\"/entity/qualifier\\"
AlinaGovoruhina marked this conversation as resolved.
Show resolved Hide resolved
search=\\"function2\\"
filterChanged=\\"function1\\"
/>"
`;

exports[`Prompts getCodeSnippet Type "filter-bar", get code snippet, min ui5Version is undefined 1`] = `
"<macros:FilterBar
id=\\"id\\"
metaPath=\\"/entity/qualifier\\"
search=\\"function2\\"
filterChanged=\\"function1\\"
/>"
`;

exports[`Prompts getCodeSnippet Type "table", get code snippet 1`] = `
"<macros:Table
id=\\"id\\"
Expand All @@ -1222,7 +1259,7 @@ exports[`Prompts getCodeSnippet Type "table", get code snippet 1`] = `
/>"
`;

exports[`Prompts getCodeSnippet Type "table", get code snippet, min ui5Version = 1.95.0 1`] = `
exports[`Prompts getCodeSnippet Type "table", get code snippet, min ui5Version = 1.95.35 1`] = `
"<macros:Table
id=\\"id\\"
metaPath=\\"qualifier\\"
Expand All @@ -1234,7 +1271,7 @@ exports[`Prompts getCodeSnippet Type "table", get code snippet, min ui5Version =
/>"
`;

exports[`Prompts getCodeSnippet Type "table", get code snippet, min ui5Version is undefined 1`] = `
exports[`Prompts getCodeSnippet Type "table", get code snippet, min ui5Version = 1.96.0 1`] = `
"<macros:Table
id=\\"id\\"
metaPath=\\"qualifier\\"
Expand All @@ -1246,6 +1283,28 @@ exports[`Prompts getCodeSnippet Type "table", get code snippet, min ui5Version i
/>"
`;

exports[`Prompts getCodeSnippet Type "table", get code snippet, min ui5Version = 1.96.25 1`] = `
"<macros:Table
id=\\"id\\"
metaPath=\\"/entity/qualifier\\"
filterBar=\\"filterBar\\"
header=\\"header\\"
headerVisible=\\"true\\"
type=\\"ResponsiveTable\\"
/>"
`;

exports[`Prompts getCodeSnippet Type "table", get code snippet, min ui5Version is undefined 1`] = `
"<macros:Table
id=\\"id\\"
metaPath=\\"/entity/qualifier\\"
filterBar=\\"filterBar\\"
header=\\"header\\"
headerVisible=\\"true\\"
type=\\"ResponsiveTable\\"
/>"
`;

exports[`Prompts getCodeSnippet get code snippet with placeholders 1`] = `
"<macros:Table
id=\\"REPLACE_WITH_BUILDING_BLOCK_ID\\"
Expand Down
18 changes: 16 additions & 2 deletions packages/fe-fpm-writer/test/unit/prompts/prompts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,22 @@ describe('Prompts', () => {
expect(result.viewOrFragmentPath.filePathProps?.fileName).toBe('Main.view.xml');
});

test.each(types)('Type "%s", get code snippet, min ui5Version = 1.95.0', async (type: PromptsType) => {
jest.spyOn(projectAccess, 'getMinimumUI5Version').mockReturnValueOnce('1.95.0');
test.each(types)('Type "%s", get code snippet, min ui5Version = 1.95.35', async (type: PromptsType) => {
jest.spyOn(projectAccess, 'getMinimumUI5Version').mockReturnValueOnce('1.95.35');
const result = promptsAPI.getCodeSnippets(type, answers[type] as SupportedGeneratorAnswers);
expect(result.viewOrFragmentPath.content).toMatchSnapshot();
expect(result.viewOrFragmentPath.filePathProps?.fileName).toBe('Main.view.xml');
});

test.each(types)('Type "%s", get code snippet, min ui5Version = 1.96.0', async (type: PromptsType) => {
jest.spyOn(projectAccess, 'getMinimumUI5Version').mockReturnValueOnce('1.96.0');
const result = promptsAPI.getCodeSnippets(type, answers[type] as SupportedGeneratorAnswers);
expect(result.viewOrFragmentPath.content).toMatchSnapshot();
expect(result.viewOrFragmentPath.filePathProps?.fileName).toBe('Main.view.xml');
});

test.each(types)('Type "%s", get code snippet, min ui5Version = 1.96.25', async (type: PromptsType) => {
jest.spyOn(projectAccess, 'getMinimumUI5Version').mockReturnValueOnce('1.96.25');
const result = promptsAPI.getCodeSnippets(type, answers[type] as SupportedGeneratorAnswers);
expect(result.viewOrFragmentPath.content).toMatchSnapshot();
expect(result.viewOrFragmentPath.filePathProps?.fileName).toBe('Main.view.xml');
Expand Down