fix: Canned Response custom tags break the GUI on enterprise #29694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6d4e6d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #29694 +/- ##
===========================================
- Coverage 46.59% 45.85% -0.74%
===========================================
Files 693 679 -14
Lines 12934 12891 -43
Branches 2241 2228 -13
===========================================
- Hits 6026 5911 -115
- Misses 6583 6664 +81
+ Partials 325 316 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
previously approved these changes
Jul 4, 2023
MartinSchoeler
previously approved these changes
Jul 4, 2023
aleksandernsilva
dismissed stale reviews from MartinSchoeler and KevLehman
via
6d4e6d1
KevLehman
approved these changes
Jul 6, 2023
MartinSchoeler
approved these changes
Jul 6, 2023
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jul 13, 2023
…reportUser * 'develop' of github.com:RocketChat/Rocket.Chat: (51 commits) feat: Add missing variants to UIKit button (#29654) refactor: Remove Accountbox usage (#29786) chore: stop importing action manager as global (#29766) chore: create FeaturePreview Component (#29759) regression: add missing translations on MenuV2 replace (#29777) test: create mock package (#29765) fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756) regression: option to start video conferences disappearing for regular users (#29763) chore: bump fuselage packages docs: Updated README file (#29770) regression: Current Chats tags filter not showing department tags (#29758) chore: `CloudRoute` to typescript (#29762) refactor: Lazy initialization on client-side (#29764) fix: Canned Response custom tags break the GUI on enterprise (#29694) regression: fix condition to `GenericMenu` gap (#29761) test: add unit tests for feature preview hooks (#29755) chore: bump fuselage deps (#29739) refactor: Changed `getUserPreference` to `useUserPreference` on `useVoipSounds` (#29744) fix: mentions and emojis inside bold, italic and strikethrough (#29391) chore: `GenericMenu` logic to add gap (#29751) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
OC-720
OC-152
SUP-47
Steps to test or reproduce
Further comments