Skip to content

Conversation

@ujjwalsolankii
Copy link
Contributor

Proposed changes (including videos or screenshots)

informations is an uncountable noun and should not be made plural. Consider changing the noun.

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2023

⚠️ No Changeset found

Latest commit: f209603

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ujjwalsolankii seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 9, 2023
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #29770 (f209603) into develop (5ff71b3) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29770      +/-   ##
===========================================
+ Coverage    46.50%   46.53%   +0.03%     
===========================================
  Files          695      695              
  Lines        13015    13015              
  Branches      2272     2272              
===========================================
+ Hits          6053     6057       +4     
+ Misses        6628     6624       -4     
  Partials       334      334              
Flag Coverage Δ
e2e 46.50% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 9f18c61 into RocketChat:develop Jul 9, 2023
gabriellsh added a commit that referenced this pull request Jul 13, 2023
…reportUser

* 'develop' of github.com:RocketChat/Rocket.Chat: (51 commits)
  feat: Add missing variants to UIKit button (#29654)
  refactor: Remove Accountbox usage (#29786)
  chore: stop importing action manager as global (#29766)
  chore: create FeaturePreview Component (#29759)
  regression: add missing translations on MenuV2 replace (#29777)
  test: create mock package (#29765)
  fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756)
  regression: option to start video conferences disappearing for regular users (#29763)
  chore: bump fuselage packages
  docs: Updated README file (#29770)
  regression: Current Chats tags filter not showing department tags (#29758)
  chore: `CloudRoute` to typescript (#29762)
  refactor: Lazy initialization on client-side (#29764)
  fix: Canned Response custom tags break the GUI on enterprise (#29694)
  regression: fix condition to `GenericMenu` gap (#29761)
  test: add unit tests for feature preview hooks (#29755)
  chore: bump fuselage deps (#29739)
  refactor: Changed `getUserPreference` to `useUserPreference` on `useVoipSounds` (#29744)
  fix: mentions and emojis inside bold, italic and strikethrough (#29391)
  chore: `GenericMenu` logic to add gap (#29751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants