refactor: Lazy initialization on client-side #29764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const convertShortName = mem( | ||
| (shortname) => { | ||
| // the fix is basically adding this .replace(/[+]/g, '\\$&') | ||
| if (typeof shortname === 'undefined' || shortname === '' || emojione.shortnames.indexOf(shortname.replace(/[+]/g, '\\$&')) === -1) { |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
|
ggazzo
approved these changes
Jul 7, 2023
Codecov Report
@@ Coverage Diff @@
## develop #29764 +/- ##
===========================================
- Coverage 46.58% 45.74% -0.84%
===========================================
Files 694 682 -12
Lines 12999 12925 -74
Branches 2251 2253 +2
===========================================
- Hits 6055 5912 -143
- Misses 6615 6689 +74
+ Partials 329 324 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
added a commit
that referenced
this pull request
Jul 13, 2023
…reportUser * 'develop' of github.com:RocketChat/Rocket.Chat: (51 commits) feat: Add missing variants to UIKit button (#29654) refactor: Remove Accountbox usage (#29786) chore: stop importing action manager as global (#29766) chore: create FeaturePreview Component (#29759) regression: add missing translations on MenuV2 replace (#29777) test: create mock package (#29765) fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756) regression: option to start video conferences disappearing for regular users (#29763) chore: bump fuselage packages docs: Updated README file (#29770) regression: Current Chats tags filter not showing department tags (#29758) chore: `CloudRoute` to typescript (#29762) refactor: Lazy initialization on client-side (#29764) fix: Canned Response custom tags break the GUI on enterprise (#29694) regression: fix condition to `GenericMenu` gap (#29761) test: add unit tests for feature preview hooks (#29755) chore: bump fuselage deps (#29739) refactor: Changed `getUserPreference` to `useUserPreference` on `useVoipSounds` (#29744) fix: mentions and emojis inside bold, italic and strikethrough (#29391) chore: `GenericMenu` logic to add gap (#29751) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
It uses aggressive approach on dynamic importing expensive modules.
Issue(s)
Steps to test or reproduce
Further comments