-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: GUI crash when editing canned response with tags via contextual bar #35679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 0a3b0b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35679 +/- ##
========================================
Coverage 59.62% 59.62%
========================================
Files 2832 2832
Lines 68357 68356 -1
Branches 15141 15149 +8
========================================
Hits 40758 40758
+ Misses 24993 24992 -1
Partials 2606 2606
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
3041f2b to
e5de417
Compare
e5de417 to
066d27e
Compare
066d27e to
7733cda
Compare
tiagoevanp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All great, I'm just concerned about the specificity of some locators in test. Role label + hasText is a possible future test leak between screens and functionalities...
Proposed changes (including videos or screenshots)
This PR fixes a crash that occurred when editing a canned response with tags via the contextual bar.
The issue was caused by an incorrect tag format being passed to the form as an array of objects instead of the expected array of strings.
Issue(s)
SUP-756
Steps to test or reproduce
Further comments
Introduced here #22767
Partially fixed here #29694