Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Apr 1, 2025

Proposed changes (including videos or screenshots)

This PR fixes a crash that occurred when editing a canned response with tags via the contextual bar.
The issue was caused by an incorrect tag format being passed to the form as an array of objects instead of the expected array of strings.

Issue(s)

SUP-756

Steps to test or reproduce

  • Access workspace
  • Get any omnichannel chat;
  • Click on “Canned responses” in the room toolbox
  • Click on a canned response with a tag
  • Click on Edit.

Further comments

Introduced here #22767
Partially fixed here #29694

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 1, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

🦋 Changeset detected

Latest commit: 0a3b0b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35679/

Built to branch gh-pages at 2025-04-10 17:12 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.62%. Comparing base (49843c8) to head (0a3b0b2).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35679   +/-   ##
========================================
  Coverage    59.62%   59.62%           
========================================
  Files         2832     2832           
  Lines        68357    68356    -1     
  Branches     15141    15149    +8     
========================================
  Hits         40758    40758           
+ Misses       24993    24992    -1     
  Partials      2606     2606           
Flag Coverage Δ
unit 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva force-pushed the fix/edit-canned-responses-ctbar branch 2 times, most recently from 3041f2b to e5de417 Compare April 2, 2025 14:14
@aleksandernsilva aleksandernsilva force-pushed the fix/edit-canned-responses-ctbar branch from e5de417 to 066d27e Compare April 2, 2025 15:23
@aleksandernsilva aleksandernsilva force-pushed the fix/edit-canned-responses-ctbar branch from 066d27e to 7733cda Compare April 2, 2025 16:51
@aleksandernsilva aleksandernsilva changed the title fix: Editing canned response with tags via contextual bar crashes the GUI fix: GUI crash when editing canned response with tags via contextual bar Apr 2, 2025
@aleksandernsilva aleksandernsilva marked this pull request as ready for review April 2, 2025 18:37
@aleksandernsilva aleksandernsilva requested review from a team as code owners April 2, 2025 18:37
@aleksandernsilva aleksandernsilva added this to the 7.6.0 milestone Apr 2, 2025
Copy link
Contributor

@tiagoevanp tiagoevanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All great, I'm just concerned about the specificity of some locators in test. Role label + hasText is a possible future test leak between screens and functionalities...

@renatobecker renatobecker added the stat: QA assured Means it has been tested and approved by a company insider label Apr 8, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 8, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 10, 2025
@aleksandernsilva aleksandernsilva added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Apr 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 10, 2025
@kodiakhq kodiakhq bot merged commit ca6870a into develop Apr 10, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/edit-canned-responses-ctbar branch April 10, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants