Skip to content

test: add unit tests for feature preview hooks #29755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 3 commits into from
Jul 7, 2023
Merged

test: add unit tests for feature preview hooks #29755

ggazzo merged 3 commits into from
Jul 7, 2023

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 7, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 007e95e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the test/feature-preview branch from b4d64e8 to ab4f68a Compare July 7, 2023 02:59
@codecov
Copy link

codecov bot commented Jul 7, 2023 •
edited
Loading

Codecov Report

Merging #29755 (760b905) into develop (e6f905d) will increase coverage by 0.74%.
The diff coverage is n/a.

❗ Current head 760b905 differs from pull request most recent head 007e95e. Consider uploading reports for the commit 007e95e to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29755      +/-   ##
===========================================
+ Coverage    45.95%   46.69%   +0.74%     
===========================================
  Files          681      694      +13     
  Lines        12916    13003      +87     
  Branches      2233     2250      +17     
===========================================
+ Hits          5935     6072     +137     
+ Misses        6665     6604      -61     
- Partials       316      327      +11
Flag Coverage Δ
e2e 46.67% <ø> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review July 7, 2023 15:16
@ggazzo ggazzo requested a review from a team as a code owner July 7, 2023 15:16
tassoevan
tassoevan previously approved these changes Jul 7, 2023
View reviewed changes
@ggazzo ggazzo merged commit bcd027d into develop Jul 7, 2023
@ggazzo ggazzo deleted the test/feature-preview branch July 7, 2023 17:51
gabriellsh added a commit that referenced this pull request Jul 13, 2023
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
b7ced52 
…reportUser

* 'develop' of github.com:RocketChat/Rocket.Chat: (51 commits)
  feat: Add missing variants to UIKit button (#29654)
  refactor: Remove Accountbox usage (#29786)
  chore: stop importing action manager as global (#29766)
  chore: create FeaturePreview Component (#29759)
  regression: add missing translations on MenuV2 replace (#29777)
  test: create mock package (#29765)
  fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756)
  regression: option to start video conferences disappearing for regular users (#29763)
  chore: bump fuselage packages
  docs: Updated README file (#29770)
  regression: Current Chats tags filter not showing department tags (#29758)
  chore: `CloudRoute` to typescript (#29762)
  refactor: Lazy initialization on client-side (#29764)
  fix: Canned Response custom tags break the GUI on enterprise (#29694)
  regression: fix condition to `GenericMenu` gap (#29761)
  test: add unit tests for feature preview hooks (#29755)
  chore: bump fuselage deps (#29739)
  refactor: Changed `getUserPreference` to `useUserPreference` on `useVoipSounds` (#29744)
  fix: mentions and emojis inside bold, italic and strikethrough (#29391)
  chore: `GenericMenu` logic to add gap (#29751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tassoevan tassoevan tassoevan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggazzo @tassoevan