Skip to content

Conversation

@csuadev
Copy link
Contributor

@csuadev csuadev commented Jun 27, 2023

Add missing variants on UIKit button.

  • Danger
  • Success
  • Warning
  • Secondary with variant

Proposed changes (including videos or screenshots)

image

Issue(s)

https://rocketchat.atlassian.net/browse/AECO-197

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2023

🦋 Changeset detected

Latest commit: 70ef4db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@rocket.chat/fuselage-ui-kit Minor
@rocket.chat/uikit-playground Minor
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@csuadev csuadev marked this pull request as ready for review June 28, 2023 14:33
@csuadev csuadev requested a review from tassoevan July 7, 2023 14:20
tiagoevanp
tiagoevanp previously approved these changes Jul 7, 2023
tiagoevanp
tiagoevanp previously approved these changes Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #29654 (70ef4db) into develop (bd231a0) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29654      +/-   ##
===========================================
- Coverage    46.93%   46.76%   -0.17%     
===========================================
  Files          690      690              
  Lines        12981    12981              
  Branches      2267     2267              
===========================================
- Hits          6092     6070      -22     
- Misses        6558     6577      +19     
- Partials       331      334       +3     
Flag Coverage Δ
e2e 46.73% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

tiagoevanp
tiagoevanp previously approved these changes Jul 7, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 10, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 12, 2023
@kodiakhq kodiakhq bot merged commit 1246a21 into develop Jul 12, 2023
@kodiakhq kodiakhq bot deleted the feat/AECO-197-UI-Kit-button-variants branch July 12, 2023 16:11
gabriellsh added a commit that referenced this pull request Jul 12, 2023
…/reportUser

* 'develop' of github.com:RocketChat/Rocket.Chat: (28 commits)
  feat: Add missing variants to UIKit button (#29654)
  refactor: Remove Accountbox usage (#29786)
  chore: stop importing action manager as global (#29766)
  chore: create FeaturePreview Component (#29759)
  regression: add missing translations on MenuV2 replace (#29777)
  test: create mock package (#29765)
  fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756)
  regression: option to start video conferences disappearing for regular users (#29763)
  Release 6.2.9
  Revert "Release 6.2.9"
  fix(meteor): `room-opened` event not dispatching when navigating cached rooms (#29718)
  chore:  device management improve readability and performance (#29712)
  chore: throttle exceptions counter increment (#29719)
  chore: Improve performance of getActiveLocalUserCount (#29681)
  Release 6.2.9
  ci: update EE license (#29684)
  ci: Add missing `context` property on compose file (#29676)
  chore: add change stream option to get full doc (#29627)
  fix(meteor): Message composer keeps recording even though permission was denied (#29526)
  fix(meteor): Video Record button disabled on iOS browsers (#29649)
  ...
gabriellsh added a commit that referenced this pull request Jul 13, 2023
…reportUser

* 'develop' of github.com:RocketChat/Rocket.Chat: (51 commits)
  feat: Add missing variants to UIKit button (#29654)
  refactor: Remove Accountbox usage (#29786)
  chore: stop importing action manager as global (#29766)
  chore: create FeaturePreview Component (#29759)
  regression: add missing translations on MenuV2 replace (#29777)
  test: create mock package (#29765)
  fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756)
  regression: option to start video conferences disappearing for regular users (#29763)
  chore: bump fuselage packages
  docs: Updated README file (#29770)
  regression: Current Chats tags filter not showing department tags (#29758)
  chore: `CloudRoute` to typescript (#29762)
  refactor: Lazy initialization on client-side (#29764)
  fix: Canned Response custom tags break the GUI on enterprise (#29694)
  regression: fix condition to `GenericMenu` gap (#29761)
  test: add unit tests for feature preview hooks (#29755)
  chore: bump fuselage deps (#29739)
  refactor: Changed `getUserPreference` to `useUserPreference` on `useVoipSounds` (#29744)
  fix: mentions and emojis inside bold, italic and strikethrough (#29391)
  chore: `GenericMenu` logic to add gap (#29751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants