Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Jul 19, 2023

Proposed changes (including videos or screenshots)

This PR reverts a few changes introduced here: #29694

Issue(s)

OC-1159
OC-1160

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

⚠️ No Changeset found

Latest commit: 468f729

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva marked this pull request as ready for review July 19, 2023 14:27
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner July 19, 2023 14:27
@aleksandernsilva aleksandernsilva changed the title regression: Storing Omnichannel tag id's instead of tag labels regression: Changed UI to send tag labels instead of tag id's Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #29867 (468f729) into release-6.3.0 (5d653cc) will decrease coverage by 0.94%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.3.0   #29867      +/-   ##
=================================================
- Coverage          46.75%   45.81%   -0.94%     
=================================================
  Files                695      682      -13     
  Lines              13018    12931      -87     
  Branches            2272     2255      -17     
=================================================
- Hits                6086     5924     -162     
- Misses              6602     6684      +82     
+ Partials             330      323       -7     
Flag Coverage Δ
e2e 45.78% <0.00%> (-0.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

MartinSchoeler
MartinSchoeler previously approved these changes Jul 19, 2023
@aleksandernsilva aleksandernsilva changed the title regression: Changed UI to send tag labels instead of tag id's regression: Reverted UI logic to send tag labels instead of tag id's Jul 20, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 21, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 21, 2023
@kodiakhq kodiakhq bot merged commit 2d6aef0 into release-6.3.0 Jul 22, 2023
@kodiakhq kodiakhq bot deleted the fix/tags branch July 22, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants