Skip to content

Conversation

@dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested a review from a team as a code owner July 7, 2023 19:27
@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023

⚠️ No Changeset found

Latest commit: c1565db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 6.3.0 milestone Jul 7, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #29762 (c1565db) into develop (28b41fb) will decrease coverage by 11.21%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #29762       +/-   ##
============================================
- Coverage    46.58%   35.37%   -11.21%     
============================================
  Files          694      582      -112     
  Lines        12999    11115     -1884     
  Branches      2251     2028      -223     
============================================
- Hits          6055     3932     -2123     
- Misses        6615     6933      +318     
+ Partials       329      250       -79     
Flag Coverage Δ
e2e 35.37% <50.00%> (-11.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

ggazzo
ggazzo previously approved these changes Jul 7, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 7, 2023
@ggazzo ggazzo merged commit ad014d1 into develop Jul 7, 2023
@ggazzo ggazzo deleted the chore/cloudRoute-ts branch July 7, 2023 23:37
gabriellsh added a commit that referenced this pull request Jul 13, 2023
…reportUser

* 'develop' of github.com:RocketChat/Rocket.Chat: (51 commits)
  feat: Add missing variants to UIKit button (#29654)
  refactor: Remove Accountbox usage (#29786)
  chore: stop importing action manager as global (#29766)
  chore: create FeaturePreview Component (#29759)
  regression: add missing translations on MenuV2 replace (#29777)
  test: create mock package (#29765)
  fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756)
  regression: option to start video conferences disappearing for regular users (#29763)
  chore: bump fuselage packages
  docs: Updated README file (#29770)
  regression: Current Chats tags filter not showing department tags (#29758)
  chore: `CloudRoute` to typescript (#29762)
  refactor: Lazy initialization on client-side (#29764)
  fix: Canned Response custom tags break the GUI on enterprise (#29694)
  regression: fix condition to `GenericMenu` gap (#29761)
  test: add unit tests for feature preview hooks (#29755)
  chore: bump fuselage deps (#29739)
  refactor: Changed `getUserPreference` to `useUserPreference` on `useVoipSounds` (#29744)
  fix: mentions and emojis inside bold, italic and strikethrough (#29391)
  chore: `GenericMenu` logic to add gap (#29751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants