fix(desktop): status bar right-click keeps its own menu (Fixes #89953) - #89979
fix(desktop): status bar right-click keeps its own menu (Fixes #89953)#89979aydnOktay wants to merge 2 commits into
Conversation
The app-wide coordinator only bailed on data-slot=context-menu-trigger. Radix Slot lets the child's data-slot win, so the status bar footer (data-slot=statusbar) never matched and right-click always opened the window-verbs fallback. Stamp a dedicated marker on ContextMenuTrigger after props and guard on that. Fixes NousResearch#89953.
|
Thanks @aydnOktay — you picked the right layer, and your fix is what ships. Three PRs landed on #89953 independently, so I consolidated them into #90507. Your two commits are cherry-picked there with authorship intact: the primitive stamps the dedicated marker and the coordinator bails on it, so every One change: I dropped the first of your two tests. It hand-wrote I also swept the other nine Superseded by #90507. |
Summary
asChildSlot lets the child'sdata-slotwin. The footer isdata-slot=statusbar, so the coordinator's[data-slot=context-menu-trigger]guard never matched andstopPropagationate the Radix menu.data-hermes-context-menu-triggeronContextMenuTrigger(after props) and bail on that marker. Any asChild surface with its owndata-slotis covered, not just the status bar.Fixes #89953.