Reject non-string content/old_text without crashing - #79356
Closed
aydnOktay wants to merge 1 commit into
Closed
Conversation
Strict providers sometimes send int/list fillers for optional string fields. MemoryStore.add/replace/remove and apply_batch called .strip() on those values and AttributeError'd mid-tool. Require real strings (null still means empty). Co-authored-by: Cursor <cursoragent@cursor.com>
alt-glitch
added
type/bug
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
1 similar comment
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MemoryStore.add/replace/removeandapply_batchcalled.strip()on raw model args.AttributeErrormid-tool instead of a clean error.target: nullwas already handled inmemory_tool; extend the same defensive posture tocontent/old_text(require real strings; null still means empty).