Clamp spawn_tree.list limit to avoid unbounded payloads - #78394
Closed
aydnOktay wants to merge 2 commits into
Closed
Clamp spawn_tree.list limit to avoid unbounded payloads#78394aydnOktay wants to merge 2 commits into
aydnOktay wants to merge 2 commits into
Conversation
Negative or huge limit values on the TUI gateway spawn_tree.list RPC could flip Python entries[:limit] into nearly-full results or return oversized JSON. Clamp to 1-500 while preserving the default of 50. Co-authored-by: Cursor <cursoragent@cursor.com>
…adapters CI was failing test_initial_connect_succeeds_on_current_generation_progress when _bare_adapter() skips __init__. Use getattr and initialize the field in the test helper. Co-authored-by: Cursor <cursoragent@cursor.com>
alt-glitch
added
type/bug
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn_tree.listlimitto 1–500 (default 50) so negative/huge values cannot flipentries[:limit]into nearly-full results or return oversized JSON._record_polling_progressfor bare/__new__test adapters missing_polling_conflict_recovery_generation(unblocks the known CI failure on main).