Conversation
normalize_search_pagination already floored offset/limit but had no upper cap, so a huge limit could inflate head -n / rg fetch sizes into tool results. Cap limit at 500 while keeping the default of 50, mirroring nearby read pagination and session list clamps. Co-authored-by: Cursor <cursoragent@cursor.com>
alt-glitch
added
type/bug
Contributor
Duplicate of #77687: both cap search_files pagination in normalize_search_pagination to prevent an unbounded limit reaching the ripgrep/head path. |
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search_files pagination already floored invalid offset and limit values but had no upper bound, so a huge limit could inflate head -n and ripgrep fetch sizes into oversized tool results. This change caps the search limit at 500 while preserving the existing default of 50, matching the hardening pattern already used by read_file pagination and nearby list clamps.