Conversation
video_generate returned host cache paths only. Under docker/ssh/modal the bytes live at /root/.hermes/cache/videos/... (or the remote home), so terminal/file follow-up on video failed even though MEDIA delivery worked. Reuse the image_generate helpers to add agent_visible_video while keeping video as the host/gateway path. Co-authored-by: Cursor <cursoragent@cursor.com>
alt-glitch
added
type/bug
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
1 similar comment
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
video_generatereturned hostvideopaths only (no sandbox annotation)./root/.hermes/cache/videos/...(or the remote home), so terminal/file follow-up onvideofailed even though gateway MEDIA delivery still worked.image_generatehelpers to addagent_visible_video/host_videowhile keepingvideoas the host/gateway path (same contract asagent_visible_image/ TTSagent_visible_file_path)._looks_like_absolute_file_pathno-ops).Before / After
videoagent_visible_video=/root/.hermes/cache/videos/...