Conversation
HERMES_GATEWAY_BUSY_ACK_ENABLED only matched the literal string true, so values like 1/on/yes (and padded true) silently suppressed busy acks. Use is_truthy_value to match the project's shared truthy contract and the sibling steer-ack aliases. Co-authored-by: Cursor <cursoragent@cursor.com>
…adapters Defensively read _polling_conflict_recovery_generation via getattr so bare/__new__ adapters cannot AttributeError during progress recording. Co-authored-by: Cursor <cursoragent@cursor.com>
alt-glitch
added
type/bug
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
Contributor
Author
|
Closing to concentrate review on a single linked product bug: #89979. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HERMES_GATEWAY_BUSY_ACK_ENABLEDwithis_truthy_valueinstead of.lower() == "true". Values like1/on/yes(and whitespace-paddedtrue) previously silently suppressed busy acks while users thought they were enabling them — aligning with the project's shared truthy contract and the sibling steer-ack aliases in the same method._polling_conflict_recovery_generation.