Skip to content

Add focused tests for unauthorized DM behavior normalization - #4234

Closed
aydnOktay wants to merge 4 commits into
NousResearch:mainfrom
aydnOktay:test/gateway-unauthorized-dm-behavior
Closed

Add focused tests for unauthorized DM behavior normalization#4234
aydnOktay wants to merge 4 commits into
NousResearch:mainfrom
aydnOktay:test/gateway-unauthorized-dm-behavior

Conversation

@aydnOktay

Copy link
Copy Markdown
Contributor

Added a new focused test file for unauthorized DM behavior normalization.
Covered accepted values (pair, ignore), whitespace/case normalization, and default fallback for invalid/non-string inputs.

@aydnOktay

Copy link
Copy Markdown
Contributor Author

I look forward to your review of this and my other PR's , sir @teknium1

@alt-glitch alt-glitch added type/test Test coverage or test infrastructure P3 Low — cosmetic, nice to have comp/gateway Gateway runner, session dispatch, delivery labels May 2, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for adding direct coverage of the normalization contract. Current main still implements that contract in gateway/config.py:133-139, while the existing tests exercise configured behavior rather than the whitespace/case and invalid-input cases in this PR.

Problems

  • The PR also includes unrelated changes to .github/workflows/supply-chain-audit.yml, agent/auxiliary_client.py, and run_agent.py; those are outside the stated gateway-test scope.
  • The run_agent.py Codex hunk is stale: current run_agent.py:5328-5331 forwards API-kwargs construction to agent/chat_completion_helpers.py:666.

Suggested changes

  • Retain the four focused assertions from tests/gateway/test_unauthorized_dm_behavior.py as a standalone test-only salvage.
  • Review the CI, auxiliary-routing, and Codex behavior changes separately against their current implementations.

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-automation Sweeper risk: may affect CI, automerge, label sync, or maintainer automation sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 12, 2026
@aydnOktay

Copy link
Copy Markdown
Contributor Author

Closing to concentrate review on a single linked product bug: #89979.

@aydnOktay aydnOktay closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-automation Sweeper risk: may affect CI, automerge, label sync, or maintainer automation sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants